Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various tests + Poison Heal fix + Transistor update #3385

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Various tests + Poison Heal fix + Transistor update #3385

merged 3 commits into from
Oct 11, 2023

Conversation

Bassoonian
Copy link
Collaborator

@Bassoonian Bassoonian commented Oct 5, 2023 •
edited
Loading

Replaces #3181

Description

Adds battle tests for Defeatist, Gale Wings, Poison Heal, Sap Sipper, Earth Eater, Steelworker, Transistor, Dragon's Maw and Rocky Payload. Fixes Poison Heal ability popup and adds a config for Transistor's Gen9 nerf.

Discord contact info

bassoonian

AsparagusEduardo
AsparagusEduardo requested changes Oct 5, 2023
View reviewed changes
test/battle/ability/defeatist.c Outdated Show resolved Hide resolved
test/battle/ability/gale_wings.c Outdated Show resolved Hide resolved
test/battle/ability/gale_wings.c Outdated Show resolved Hide resolved
test/battle/ability/gale_wings.c Show resolved Hide resolved
test/battle/ability/poison_heal.c Show resolved Hide resolved
test/battle/ability/poison_heal.c Outdated Show resolved Hide resolved
test/battle/ability/poison_heal.c Outdated Show resolved Hide resolved
test/battle/ability/sap_sipper.c Outdated Show resolved Hide resolved
@Bassoonian
Copy link
Collaborator Author

Ready for re-review. Also added tests for Earth Eater as well as Steelworker and its variants, and added a config for Transistor (which is nerfed in Gen9+).

@AsparagusEduardo
Copy link
Collaborator

Ready for re-review. Also added tests for Earth Eater as well as Steelworker and its variants, and added a config for Transistor (which is nerfed in Gen9+).

Update the description and title with the new changes.

@Bassoonian Bassoonian changed the title Defeatist, Gale Wings, Poison Heal, Sap Sipper tests Various tests + Poison Heal fix + Transistor update Oct 6, 2023
@Bassoonian
Copy link
Collaborator Author

Done!

mrgriffin
mrgriffin previously approved these changes Oct 8, 2023
View reviewed changes
src/battle_util.c Show resolved Hide resolved
AsparagusEduardo
AsparagusEduardo requested changes Oct 9, 2023
View reviewed changes
test/battle/ability/rocky_payload.c Outdated Show resolved Hide resolved
test/battle/ability/sap_sipper.c Outdated Show resolved Hide resolved
test/battle/ability/steelworker.c Outdated Show resolved Hide resolved
test/battle/ability/transistor.c Outdated Show resolved Hide resolved
test/battle/ability/poison_heal.c Outdated Show resolved Hide resolved
test/battle/ability/poison_heal.c Outdated Show resolved Hide resolved
test/battle/ability/gale_wings.c Show resolved Hide resolved
test/battle/ability/dragons_maw.c Outdated Show resolved Hide resolved
src/battle_util.c Show resolved Hide resolved
@Bassoonian
Copy link
Collaborator Author

Should be good to go other than the 5325/4096 multiplier, which I'll leave for @AsparagusEduardo to figure out :)

@AsparagusEduardo
Copy link
Collaborator

Based on Showdown's code, we mainly need to change some stuff to use 5325/4096 as well, so this is specific seems good to go to me.
I'll open a separate issue for this.

@AsparagusEduardo AsparagusEduardo merged commit eedc617 into rh-hideout:master Oct 11, 2023
1 check passed
@AsparagusEduardo
Copy link
Collaborator

I just realized, we could use some of the other fpmath.h functions, like uq4_12_multiply_half_down

@AsparagusEduardo
Copy link
Collaborator

crap, the transistor update should've gone to upcoming

@Bassoonian Bassoonian deleted the jaspersbattletests branch October 24, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

@mrgriffin mrgriffin mrgriffin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bassoonian @AsparagusEduardo @mrgriffin