EFFECT_CHILLY_RECEPTION #3379
Merged
EFFECT_CHILLY_RECEPTION #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 1, 2023 23:35
AlexOn1ine
reviewed
Oct 19, 2023
AlexOn1ine
reviewed
Oct 19, 2023
Skeli789
suggested changes
Oct 20, 2023
data/battle_scripts_1.s
Outdated
| waitmessage B_WAIT_TIME_LONG | ||
| attackstring | ||
| ppreduce | ||
| jumpifhalfword CMP_COMMON_BITS, gBattleWeather, B_WEATHER_SUN_PRIMAL, BattleScript_ExtremelyHarshSunlightWasNotLessened |
There was a problem hiding this comment.
The user is supposed to still switch out even if the weather can't be changed.
Also, these three jumps appear 8 times in this file. You should make a macro so you don't need to duplicate even more code than already is.
There was a problem hiding this comment.
This was actually a mistake, but what I wanted to do didn't work anyway... Oops! I've updated the logic for this portion to always switch though. There might still be a better way to do what I did. I'm all ears!
I also went ahead and made a macro for those other instances of this jump even though I don't use it here anymore.
added 4 commits
October 30, 2023 17:32
* Created CheckPrimalWeather macro for Weather Effects * Updated Chilly Reception logic to switch even if weather doesn't change Testing Updates
Skeli789
suggested changes
Oct 31, 2023
added 3 commits
November 2, 2023 14:31
* Move Chilly Reception animation to always play (even when weather change fails)
Skeli789
suggested changes
Nov 5, 2023
added 3 commits
November 14, 2023 13:25
AlexOn1ine
reviewed
Nov 20, 2023
AlexOn1ine
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements MOVE_CHILLY_RECEPTION. Animation borrows from a bunch of other moves in combination and could maybe use some refinement. I copied the base tests from U-Turn and I'm not sure if I covered everything that's necessary in the modifications; please let me know.
First PR, so please let me know if there are issues on the administrative side! Feel free to be critical of coding standards etc. so I can better learn going forward!
Images
Issue(s) that this PR fixes
Fixes #2505
Discord contact info
rapidnutcracker