Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Battle/Shell Armor + crit chance Tests #3377

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

AlexOn1ine
Copy link
Collaborator

  • Fixes Battle Armor and Shell Armor not blocking critical hits.
  • Removed STATUS3_CANT_SCORE_A_CRIT from CalcCritChanceStageArgs because it isn't used anywhere else but kept it in constants/battle.h.
  • Added some crit chance tests and moved Dire Hit increases a battler's critical hit chance by 2 stages to crit_chance.c.
  • Fix provided by MGriffin in test_runner_battle.c for RNG_CRITICAL_HIT.

Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, solid work!

test/battle/crit_chance.c Outdated Show resolved Hide resolved
test/battle/crit_chance.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Oct 4, 2023

Made a minor record ability change (Idk actually how beneficial this was. Likely doesn't matter)

@DizzyEggg DizzyEggg merged commit b18d018 into rh-hideout:master Oct 4, 2023
1 check passed
@AlexOn1ine AlexOn1ine deleted the crit_chance branch October 9, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants