flinch tests + protect/flinch fix #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was watching a playthrough of Inclement Emerald and noticed this bug happening.
Basically, Protect could fail if it was used once, then mon flinched, and used again. Reason was the protect cmd was reading flags from a 0xFFFF move which was some random data(which happened to have the FLAG_PROTECTION_MOVE set).
Edit: Now that I think about it, this either happens on vanilla Emerald too or GF got lucky and the random data happened to act as FLAG_PROTECTION_MOVE was 0.