Wild battle tests + tests for exp points #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOuroboros
reviewed
Sep 24, 2023
data/battle_scripts_2.s
Outdated
| @@ -153,6 +153,7 @@ BattleScript_PrintCaughtMonInfo:: | |||
| getexp BS_TARGET | |||
| sethword gBattle_BG2_X, 0 | |||
| BattleScript_TryPrintCaughtMonInfo: | |||
| jumpifbattletype BATTLE_TYPE_RECORDED, BattleScript_GiveCaughtMonEnd | |||
mrgriffin
requested changes
Sep 26, 2023
|
Forgot to thank you in my review, but this is awesome work! 😅 |
|
Should be ready for review again |
mrgriffin
approved these changes
Sep 27, 2023
fdeblasio
pushed a commit
to fdeblasio/pokeemerald-expansion
that referenced
this pull request
Oct 1, 2023
* Add WIld Battles to test runner + exp tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPERIENCE_BARwhich works similarly toHP_BAROtNamewhich changes original trainer's name. Its use is to generate a traded pokemon.What next? I would say that'd be wild double battles, trainer battles and ai vs ai trainer battles. Though it's probably gonna take some more work, so I'd rather put it outside the scope of this PR.