Fix Shiny Charm doing too many rerolls by default #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The config name should probably be changed to something like SHINY_CHARM_ADDITIONAL_ROLLS, or the code changed to mimic the current config to not be confusing. |
Good idea, I'll do the first one. |
AsparagusEduardo
requested changes
Sep 30, 2023
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
AsparagusEduardo
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes us accidentally adding 3 rerolls with the shiny charm resulting in 4 total rolls for shininess, when it should be only 2 like on cart (3 total).
This is corroborated by the SV shiny rate chart by Anubis: https://twitter.com/Sibuna_Switch/status/1593266100627709957
Discord contact info
kittenchilly