-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Modern as default #3305
Setting Modern as default #3305
Conversation
The future is now |
The CI seems to still build tests with agbcc. (But also they are currently broken on modern) |
Oh yeah... idk how others feel, but I'd really want the tests to run and pass before we merge this PR. There was a tiny amount of discussion on Discord, but nothing particularly helpful. I haven't had the time to look into this, but a reasonable first step might be to look at the failing tests running in a visual mgba. |
I completely agree. |
Set as draft until tests work on modern. |
CI set to Modern and tests pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to merge this? 👀
Can we rebase to upcoming one more time to get CI confirmation? :) |
EDIT: SBird already PRed this to
Good call, it's complaining about my ModifyPersonalityForNature test :kekw: diff --git a/test/battle/trainer_control.c b/test/battle/trainer_control.c
index 99bea0e8cc..192b12980c 100644
--- a/test/battle/trainer_control.c
+++ b/test/battle/trainer_control.c
@@ -123,7 +123,7 @@ TEST("CreateNPCTrainerPartyForTrainer generates different personalities for diff
TEST("ModifyPersonalityForNature can set any nature")
{
- u32 personality, nature, j, k;
+ u32 personality = 0, nature = 0, j, k;
for (j = 0; j < 64; j++)
{
for (k = 0; k < NUM_NATURES; k++) |
Yeah that sounds right. |
I'm out until Friday, so someone can PR to this PR the merge with upcoming plus these changes and I'll accept it. |
|
This reverts commit 81cbbdb.
Description
@gruxor is happy.
make
now does modern, whilemake agbcc
compiles using agbcc.make modern
still does its thing.Discord contact info
AsparagusEduardo