HGSS Style Pokedex #3288
Merged
HGSS Style Pokedex #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more ui, BROKEN atm type icons in info screen working topbar dpad for switching and white mon name initial working stats screen additional stats, proper move list array Working stats screen, all infos in, all icons in, buggy when switching Fixed sprite bug, proper sprite destruction, works with old compiler new navigation: info>area>stats power+accuracy text, change of positions layout for stats screen, other screen visually broken new stats layout properly working plus toggle infos show lvl of LevelUpMove and TM/HM of TMHM_Move 3 dashes for EggMoves and CORRECT icon for TM/HMs pog improved layout and contest move data! TutorMoves now available hold dpad to scroll, pure relieve search by move code working 6evs, 16 character move names, tripple digit moves, new eduardo layout working tileset, info screen no correct xy layout for elements yet new list menu start new layout working, only missing stats bars new list, new search fixed area screen change and fixed "new caught" bug (type icons)
* Changed comment method to avoid conflict with Pokemon Expansion. * Changes the way level up moves are read if it detects either Battle Engine or Pokémon Expansion. * Support for Battle Engine's spit icon.
…e for the bars altered from DizzyEgg
…ety, added constant to make custom dark palette switch easy
changed where the bg is cleared
…cry screen, thanks to @AsparagusEduardo for pointing it out
…r own moveset, credits @aarant
…thub.com/pret/pokeemerald into tx_pokedexPlus_hgss
- reordered all hgss code - cleanup needed! - restored the vanilla dex
|
Note for the reviewer: DON'T squash or rebase this one to avoid conflicts with users that already use this feature branch. |
|
Ready for Review! |
AsparagusEduardo
requested changes
Sep 10, 2023
|
Applied requested changes. |
AsparagusEduardo
requested changes
Sep 14, 2023
|
Oh and one more thing, in the Discord we discussed adding special handling for Mew so that it shows a single entry that says "ALL" for TMs and Tutors. Could you add this? |
If not, I'll try to PR it myself. |
AsparagusEduardo
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds @TheXaman's HGSS Style Pokedex
Images
Discord contact info
aaghat