More weather and type-specific tests #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
requested changes
Sep 8, 2023
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
|
There's still some unadressed comments |
AsparagusEduardo
requested changes
Oct 11, 2023
|
All reviews applied, finally. |
AsparagusEduardo
requested changes
Oct 15, 2023
test/battle/move_effect/synthesis.c
Outdated
| } | ||
| } | ||
|
|
||
| SINGLE_BATTLE_TEST("Synthesis recovers 1/4 of the user's max HP in Rain") |
There was a problem hiding this comment.
Haven't addressed this yet.
test/battle/move_effect/poison_hit.c
Outdated
| @@ -37,3 +38,19 @@ SINGLE_BATTLE_TEST("Poison Sting cannot poison Poison-type") | |||
| NOT STATUS_ICON(opponent, poison: TRUE); | |||
| } | |||
| } | |||
|
|
|||
| SINGLE_BATTLE_TEST("Poison cannot be inflicted on Steel-type Pokémon") | |||
There was a problem hiding this comment.
Haven't addressed this yet.
test/battle/move_effect/solar_beam.c
Outdated
| ASSUME(gBattleMoves[MOVE_SOLAR_BEAM].effect == EFFECT_SOLAR_BEAM); | ||
| } | ||
|
|
||
| SINGLE_BATTLE_TEST("Solar Beam can be used instantly in Sunlight") |
There was a problem hiding this comment.
Haven't addressed this yet.
AsparagusEduardo
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most weather tests should be implemented now, as well as a few weather-adjacent and type-specific tests.
Also re-orders a few tests to be more consistent with eachother.