Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Ultra Burst #3221

Merged
merged 17 commits into from
Aug 30, 2023
Merged

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Aug 11, 2023

Description

Adds the ability for Necrozma Dusk Mane and Necrozma Dawn Wings to undergo Ultra Burst if holding an Ultranecrozium Z and the player has a Z Ring, transforming them into Ultra Necrozma.
Ultra Burst can be defined by putting the relevant pokemon in a form table with a z crystal held item, much like mega evolution. It is triggered and used almost exactly like mega evolution, except instead of a mega stone and mega ring, its a z crystal and z ring.

Images

ultraburst2

Issue(s) that this PR fixes

Closes #2288

Discord contact info

kittenchilly

@AsparagusEduardo
Copy link
Collaborator

Just like how Mega Evolution has tests, Ultra Burst needs tests as well.
I recommend the following, based on Mega Evolution's:

  • "Dusk Mane Necrozma can Ultra Burst holding Ultranecrozium Z"
  • "Ultra Burst's order is determined by Speed - opponent faster"
  • "Ultra Burst's order is determined by Speed - player faster"
  • "Ultra Burst affects turn order"
  • "Ultra Burst happens after switching, but before Focus Punch-like Moves"
  • "Ultra Burst and Mega Evolution can happen on the same turn"

@kittenchilly
Copy link
Author

Just like how Mega Evolution has tests, Ultra Burst needs tests as well. I recommend the following, based on Mega Evolution's:

  • "Dusk Mane Necrozma can Ultra Burst holding Ultranecrozium Z"
  • "Ultra Burst's order is determined by Speed - opponent faster"
  • "Ultra Burst's order is determined by Speed - player faster"
  • "Ultra Burst affects turn order"
  • "Ultra Burst happens after switching, but before Focus Punch-like Moves"
  • "Ultra Burst and Mega Evolution can happen on the same turn"

Alright, done, and they all pass.

@AsparagusEduardo
Copy link
Collaborator

Looks good, just needs to solve conflicts.

@AsparagusEduardo AsparagusEduardo merged commit deb2055 into rh-hideout:upcoming Aug 30, 2023
1 check passed
@97mos
Copy link

97mos commented Sep 1, 2023

What about the indicator that replaces the Lv like for mega and the primal reversions?

@LOuroboros
Copy link
Collaborator

What about the indicator that replaces the Lv like for mega and the primal reversions?

Ultra Burst doesn't have one of its own, Necrozma's level is displayed normally without any extra icons.

citra-qt_20230901_221414889

@kittenchilly kittenchilly deleted the ultraburst branch September 2, 2023 20:19
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants