Prevent certain status moves when item is known + Fake Out changes #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should be an AI_DATA->holdEffects array to use instead ofAI_GetHoldEffect, which is computed up front for efficiency |
fix ShouldTryToFlinch fix some mess up fix of fix of mess up
Changed to AI_DATA->holdEffects |
AlexOn1ine
changed the title
AlexOn1ine
changed the title
ghoulslash
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AI_GetHoldEffectto prevent the AI from going for unfavorable moves if hold effect becomes knownShouldFakeOutchanges. Mostly new additions that prevent flinching but also removedShouldTryToFlinchfrom this functionShouldTryToFlinchaddition and now returns zero if conditions don't apply. I personally think that a move shouldn't get an increase if there is only a chance (unless the chance is increased) for the effect to occur because it might mess with the highest damage move which is likely better in most casesEFFECT_EARTHQUAKEandEFFECT_MAGNITUDEcheck