-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Mortal Spin and Population Bomb #3178
Adds Mortal Spin and Population Bomb #3178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some changes to Triple Kick and multi hit moves in general. I would feel more comfortable merging this PR if we got tests for Triple Kick and moves like Double Kick, Fury Swipes, etc. Also their interactions with Skill Link, when they can miss, when the can't miss, etc.
Added Skill Link Tests for I wasn't able to write tests for Triple Kick and Population Bomb because it doesn't seem you can check their accuracy correctly so @AsparagusEduardo suggested to just add the |
The tests on github don't pass
but they pass for me 🤔
|
If you run with |
All good
|
fix for small bug introduced in the latest commit
51f58e0
to
5167b01
Compare
92010e9
to
c44fbae
Compare
c44fbae
to
8ee3a3c
Compare
Closes #2497 (Credit: Lunos)
Closes #2493