Fix debug memory overflow #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TheXaman's debug menu used PC_ITEMS_COUNT as an artifact, which would lead to memory issues if it was reduced in value (more specifically any reduction below 19). This PR fixes this issue by introducing a new DEBUG_MAX_MENU_ITEMS and a failsafe by limiting totalItems to the value of DEBUG_MAX_MENU_ITEMS if it would be larger, causing a limit in the amount of items shown rather than silently overwriting memory.
Discord contact info
bassoonian