Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bad Dreams ability pop-up + tests #3131

Merged
merged 6 commits into from
Jul 16, 2023
Merged

Fix Bad Dreams ability pop-up + tests #3131

merged 6 commits into from
Jul 16, 2023

Conversation

DizzyEggg
Copy link
Collaborator

Replaces #2951

Fixes:

  • Bad Dreams' pop-up now shows up only if it can activate on opposing sleeping mons
  • lag issue where the pop-up wouldn't hide smoothly
  • the pop-up now hides when it faints a target, previously it would just stay on the screen
  • added tests for the ability

@AsparagusEduardo
Copy link
Collaborator

imagen

@DizzyEggg
Copy link
Collaborator Author

imagen

I know, but something must be wrong with the tests code, because when watching the tests run in m-gba it plays exactly like in the test, even though it fails.

@DizzyEggg
Copy link
Collaborator Author

imagen

Read for review & merge

@mrgriffin mrgriffin merged commit 381aa58 into rh-hideout:master Jul 16, 2023
@mrgriffin mrgriffin mentioned this pull request Jul 16, 2023
Closed
@DizzyEggg DizzyEggg deleted the bad_dreams_test branch June 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgriffin mrgriffin mrgriffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DizzyEggg @AsparagusEduardo @mrgriffin @ShaeTsuPog