Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled species now default their graphics to SPECIES_NONE #3116

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Jul 7, 2023

Description

Ported from #2363.

Before, disabled species would crash/cause issues. This also fixes SPECIES_NONE sprites and icon.
Also streamlined adding new gender differences

Images

mGBA_k2rxfy1nVA

Discord contact info

asparaguseduardo

- If it has a female sprite/palette, it's loaded.
- If it the species is enabled and it has a sprite/palette, it's loaded.
- Otherwise, load the SPECIES_NONE graphics.
Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AsparagusEduardo AsparagusEduardo merged commit 0efc9a2 into rh-hideout:upcoming Jul 13, 2023
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/cleanup/defaultSprite branch July 13, 2023 00:11
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants