Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed tests are now listed in the total #3073

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Failed test names are now displayed on the test totals.
Due to how Test_ExitWithResult is handled, I can't quite figure out how to show show the corresponding file/line as well.

Images

imagen

Discord contact info

AsparagusEduardo

Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! No more scrolling up 🎉

tools/mgba-rom-test-hydra/main.c Outdated Show resolved Hide resolved
test/test_runner_battle.c Outdated Show resolved Hide resolved
@AsparagusEduardo
Copy link
Collaborator Author

Changes applied, ready for re-review.

@mrgriffin mrgriffin merged commit 5f29ae6 into rh-hideout:master Jul 14, 2023
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/master/testFailedList branch August 12, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants