Test Runner support for illegal abilities #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For bugfixes and tests, please change the target branch to |
AsparagusEduardo
added
category: battle-mechanic
AsparagusEduardo
approved these changes
Jun 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There isn't a way to test abilities that aren't attached to Pokémon yet, so I added a way to force abilities in tests. Thanks to @mrgriffin for mentioning
gBattleStruct->overwrittenAbilities, since I think this is actually a pretty non-hacky way of making things work. I haven't tested it in edge cases like Skill Swap or Trace, but I want to say it would work fine.Images
Discord contact info
Agustin#1522