Allow Cycling Through Balls in the Last Ball Used Menu #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here gBallToDisplay is not written when the last_ball_used setting is off but is still used
voloved
force-pushed
the
last_ball_used_cycle
branch
from
9a765a5
to
6ad4854
Compare
…indow is present to avoid overwriting other palettes
voloved
force-pushed
the
last_ball_used_cycle
branch
from
96609dc
to
c8584ec
Compare
|
Conflicts 👀 |
AsparagusEduardo
requested changes
Aug 12, 2023
voloved
force-pushed
the
last_ball_used_cycle
branch
from
0fbda9e
to
1ef2668
Compare
…n; Made the use cycle option on by default
voloved
force-pushed
the
last_ball_used_cycle
branch
from
1ef2668
to
3e5b7b6
Compare
AsparagusEduardo
approved these changes
Aug 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #3034, but is pointing to the correct branch of the contributor's repo.
Context in the Discord: https://discord.com/channels/419213663107416084/419214240277200898/1112508362375041107
Description
Allows cycling through the balls in your inventory.
It's off by default. Setting B_LAST_USED_BALL_CYCLE to TRUE will allow it to work (assuming B_LAST_USED_BALL also is set to TRUE).
Toggling is done by holding the B_LAST_USED_BALL_BUTTON and clicking the D-Pad. Up and Left go to the previous ball in your bag and Down and Right go to the next ball. It wraps around, so if I choose the previous ball and am looking at the first slot's ball, it'll cycle to the last slot.
Throwing the ball now goes off when the B_LAST_USED_BALL_BUTTON is released. If that button is held and the user wants to cancel throwing a ball, they can press B_LAST_USED_BTN_CANCEL_CYC before letting go.
Having B_LAST_USED_BALL_CYCLE set to FALSE has everything behave the same as before this PR.
Images
Discord contact info
devolov#4853