Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized battle gender checks #3020

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Aka: Edu's PR Idea N°1 for when he had to rest his hands.

Discord contact info

AsparagusEduardo#6051

Copy link
Collaborator

@AgustinGDLV AgustinGDLV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really find anything I'd want to change other than u8 to bool8 for AreBattlersOfSameGender. Really nice change, makes everything way more readable!

src/battle_util.c Outdated Show resolved Hide resolved
include/battle_util.h Outdated Show resolved Hide resolved
@AsparagusEduardo
Copy link
Collaborator Author

AreBattlersOfSameGender

By this mean that I should rename AreBattlersOfOppositeGender?

@AgustinGDLV
Copy link
Collaborator

AreBattlersOfSameGender

By this mean that I should rename AreBattlersOfOppositeGender?

No I just can't read.

@AsparagusEduardo AsparagusEduardo merged commit d0e6ea7 into rh-hideout:upcoming May 27, 2023
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/cleanup/gender branch May 28, 2023 01:41
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants