Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wrong mon position for scripted wild doubles #2996

Merged
merged 1 commit into from
May 14, 2023
Merged

Fix for wrong mon position for scripted wild doubles #2996

merged 1 commit into from
May 14, 2023

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented May 11, 2023 •
edited
Loading

Description

Fixes issue with scripted wild double battles where one mon was centered. Issue was caused by gEnemyPartyCount having the wrong value because the second mon was set to the 4th slot in function CreateScriptedDoubleWildMon. The correct count was needed by WhichBattleCoords.
Changes were tested with the script provided by ghoulslash:

	givemon SPECIES_XATU, 40, 0
	givemon SPECIES_AGGRON, 40, 0
	setwildbattle SPECIES_VOLCARONA, 40, 0, SPECIES_VOLCARONA, 35, 0
	dowildbattle

Images

pokeemerald-17

Issue(s) that this PR fixes

Fixes #2993

Discord contact info

AlexOnline#2331

@AsparagusEduardo AsparagusEduardo merged commit f6f0e5f into rh-hideout:upcoming May 14, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Merged
@AlexOn1ine AlexOn1ine deleted the wild_double_battle branch July 5, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Wild) doubles healthboxes are not aligned correctly
2 participants
@AlexOn1ine @AsparagusEduardo