Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix several issues in BS_ItemCureStatus #2916

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix several issues in BS_ItemCureStatus #2916

merged 2 commits into from
Apr 17, 2023

Conversation

u8-Salem
Copy link

@u8-Salem u8-Salem commented Apr 16, 2023 •
edited
Loading

Description

  1. gBattleMons was using party indices instead of battle indices, therefore only ever healing a mon whichs party index matches with its battle index.
  2. added brackets for readability
  3. fix nightmare only being healed in double battles by moving the check into the scope of the entire function.

fixes #2919

Discord contact info

Salem#3258

@u8-Salem u8-Salem changed the title fix nightmare status only being healed in doubles fix several issues in BS_ItemCureStatus Apr 17, 2023
@u8-Salem u8-Salem mentioned this pull request Apr 17, 2023
Closed
@AsparagusEduardo AsparagusEduardo merged commit afdfe15 into rh-hideout:upcoming Apr 17, 2023
@u8-Salem u8-Salem deleted the nightmareFix branch April 17, 2023 20:08
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Heal only heals lead Pokemon from confusion
2 participants
@u8-Salem @AsparagusEduardo