Fixed switch-in abilities activating on terrain change

[AgustinGDLV]

Description

Fixes #2880. This PR removes an erroneous call to activateswitchinabilities in the TerrainSeed loop and combines both the TerrainSeedLoop and TerrainAbilitiesLoop into one loop for terrain effects so you don't have to call each individually (and so it doesn't have to loop over every battler twice).

This PR also adds tests for every terrain effect! This includes some edge cases for Psychic Terrain that appear to be inaccurate at the moment, so they have been marked with KNOWN_FAILING. These bugs have been pointed out in #2882, but are not fixed in this PR.

[ghoulslash]

I think it should instead be replaced with a call to ActivateTerrainChangeAbilities. On mobile so can't confirm right now but that's my intuition

[AgustinGDLV]

I think it should instead be replaced with a call to ActivateTerrainChangeAbilities. On mobile so can't confirm right now but that's my intuition

BattleScript_EffectMistyTerrain:
BattleScript_EffectGrassyTerrain:
BattleScript_EffectElectricTerrain:
BattleScript_EffectPsychicTerrain:
	attackcanceler
	attackstring
	ppreduce
	setterrain BattleScript_ButItFailed
	attackanimation
	waitanimation
	printfromtable gTerrainStringIds
	waitmessage B_WAIT_TIME_LONG
	playanimation BS_ATTACKER, B_ANIM_RESTORE_BG
	call BattleScript_ActivateTerrainAbilities
	call BattleScript_TerrainSeedLoop
	goto BattleScript_MoveEnd

The terrain seed script and the terrain abilities script are called separately in all the terrain effect scripts, so it doesn't need to be swapped. This bug is probably a leftover from these scripts being changed when Quark Drive was added.

[ghoulslash]

I think it should instead be replaced with a call to ActivateTerrainChangeAbilities

Those loops ought to be merged then. No reason to loop twice when you can check seeds and terrain change abilities in the same loop iteration

[AgustinGDLV]

Oh huh, good idea. I will commit that when I can.

[AgustinGDLV]

Updated and ready for review!