Refactor Mega Evolution indicator sprite #2805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2404
Fixes #2368 (Doesn't really fix the issue, because in vanilla and expansion partner mons start with index 3, if that was changed then it's a problem with the hack)
Fixes #1984
Also fixes a plethora of issues with the current implementation of how Mega Evolution indicator sprite work. It was buggy as hell, you can set up a 2v2 battle with megas on each side, and the sprites can get really glitchy. I tried to fix it, but it was a mess so I decided to rewrite it from scratch.
The workflow of the indicators sprite is like this:
Also: