Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper symbol name styles for Jangmo-o family #2739

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Ho-Oh's symbols were standarized as HoOh, so it made sense to do the same for these two.

Discord contact info

AsparagusEduardo#6051

@AsparagusEduardo AsparagusEduardo changed the title Use proper symbol styles for Hakamo-O and Kommo-O Use proper symbol name styles for Hakamo-O and Kommo-O Feb 24, 2023
@BuffelSaft
Copy link
Collaborator

Should probably do this for Jangmo-o at the same time, but if you'd rather that be a separate PR this is good to go.

@AsparagusEduardo AsparagusEduardo changed the title Use proper symbol name styles for Hakamo-O and Kommo-O Use proper symbol name styles for Jangmo-o family Feb 25, 2023
@AsparagusEduardo
Copy link
Collaborator Author

Should probably do this for Jangmo-o at the same time, but if you'd rather that be a separate PR this is good to go.

For a moment I thought Jangmo-o was already handled but I was wrong. PR updated.

@BuffelSaft
Copy link
Collaborator

BuffelSaft commented Feb 25, 2023

One last thing, it seems their footprints are in a different format:

[SPECIES_JANGMO_O] = gMonFootprint_Jangmo_o,
[SPECIES_HAKAMO_O] = gMonFootprint_Hakamo_o,
[SPECIES_KOMMO_O] = gMonFootprint_Kommo_o,

Do you want to fix that too?

@AsparagusEduardo
Copy link
Collaborator Author

Fixed

@BuffelSaft BuffelSaft merged commit deb3109 into rh-hideout:upcoming Feb 26, 2023
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/cleanup/Moo branch February 28, 2023 02:50
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants