Implement Customizable NPC Trainer Parties

[SBird1337]

Description

Implements fully customizable trainer parties for enemy trainers according to the following structure:

struct TrainerMonCustomized
{
    const u8 *nickname;
    const u8 *ev;
    u32 iv;
    u16 moves[4];
    u16 species;
    u16 heldItem;
    u16 ability;
    u8 lvl;
    u8 ball;
    u8 friendship;
    u8 nature : 5;
    bool8 gender : 2;
    bool8 isShiny : 1;
};

Discord contact info

Karathan#1337

[SBird1337]

added a COMPOUND_STRING macro to define strings as compound literals:

.nickname = COMPOUND_STRING("asdf")

[SBird1337]

rebased to upcoming, squashed and addressed some changes. Could still need some tests.

[Jaizu]

Stats need to be recalculated when using evs/ivs, needs a CalculateMonStats(&party[i]);

[Jaizu]

The macro for mon evs doesn't compile, please change it to #define TRAINER_MON_EVS(hp, atk, def, speed, spatk, spdef) ((const u8[6]){hp,atk,def,spatk,spdef,speed})

[SBird1337]

addressed the reviews and added a TRAINER_PARTY_NATURE(nature) macro to account for natures being off-by-one.

[SBird1337]

added some tests, fixed some issues found by the tests.

Ready for review :)

[ghoulslash]

I think this is a perfect opportunity to remove the TrainerMonPtr union, since its completely unnecessary and I've seen many posts expressing confusion about trying to assign items, etc, without the proper pointer definition or party flag. It would be much simpler from a user and developer to have just struct TrainerMonCustomized *party, and in CreateNPCTrainerParty, only assign fields if the field value is non-zero rather than checking e.g. F_TRAINER_PARTY_HELD_ITEM

[SBird1337]

I think this is a perfect opportunity to remove the TrainerMonPtr union, since its completely unnecessary and I've seen many posts expressing confusion about trying to assign items, etc, without the proper pointer definition or party flag. It would be much simpler from a user and developer to have just struct TrainerMonCustomized *party, and in CreateNPCTrainerParty, only assign fields if the field value is non-zero rather than checking e.g. F_TRAINER_PARTY_HELD_ITEM

I kinda agree, the reason I left it in is because the new structure is considerably larger than the old ones. So it would increase the ROM size. I have not made accurate calculations, but its not neglectable

[ghoulslash]

As per discord discussion, trainer party union will be removed at a later date