Fix switch-in abilities activating on an empty field #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOuroboros
reviewed
Feb 20, 2023
| || AbilityBattleEffects(ABILITYEFFECT_TRACE2, 0, 0, 0, 0)) | ||
| return; | ||
| // Don't activate switch-in abilities if the opposing field is empty. | ||
| // This could happen when a mon uses explosion and causes everyone to faint. |
There was a problem hiding this comment.
Then maybe, now that we have this, we wouldn't need to keep the VARIOUS_JUMP_IF_NO_VALID_TARGETS which I explicitly added to solve the interaction with Explosion? 👀
There was a problem hiding this comment.
Done, I removed VARIOUS_JUMP_IF_NO_VALID_TARGETS
mrgriffin
reviewed
Feb 21, 2023
Co-authored-by: LOuroboros <[email protected]>
mrgriffin
approved these changes
Feb 22, 2023
This was referenced Feb 22, 2023
Merged
This was referenced Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2619
Fixes #2371
Takes care of PRs #2622 and #2148.
Added tests for Download and Intimidate.
