Refactored incense baby checks into table and added Gen 9 config.

[AsparagusEduardo]

Description

Title.

Discord contact info

AsparagusEduardo#6051

[mrgriffin]

It might be nice to use a struct for this, e.g.:

static const struct {
  u16 parentSpecies;
  u16 item;
  u16 babySpecies;
} sIncenseBabyTable[] =
{
    ... // As before.

Then the loop can become:

    for (i = 0; i < ARRAY_COUNT(IncenseBabyTable); i++)
    {
        if (sIncenseBabyTable[i].babySpecies == *species && motherItem != sIncenseBabyTable[i].item && fatherItem != sIncenseBabyTable[i].item)
            *species = sIncenseBabyTable[i].parentSpecies;
    }

(Even if not, probably a good idea to make your array static const)

Also, I'm not sure about my choice of parentSpecies as a name, because that sounds like it would be what the mother or father are, but e.g., mother and father could both be Raichu and yet parentSpecies is Pikachu 🤷

[AsparagusEduardo]

Fixed compile and applied suggestions

[Jaizu]

I think you might need some ifdefs to make sure the game compiles without having all Pokémon from other gens enabled.

[AsparagusEduardo]

I think you might need some ifdefs to make sure the game compiles without having all Pokémon from other gens enabled.

The species defines are still present when the generation toggles are disabled, so it should compile. However, you are right that getting a gen 4 species shouldn't happen when those are scrubbed. Will fix that.

[ghoulslash]

fix conflicts and suggestions and looks good

[AsparagusEduardo]

fix conflicts and suggestions and looks good

Can I take the chance to add a table for the Pichu/Volt Tackle interaction? Or should I leave that for a separate PR?

[ghoulslash]

fix conflicts and suggestions and looks good

Can I take the chance to add a table for the Pichu/Volt Tackle interaction? Or should I leave that for a separate PR?

seems fine to me

[AsparagusEduardo]

Ready for re-review

[AsparagusEduardo]

Now properly ready ^^;