Minor Roost fixes/cleanup #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRs to the expansion should point to the |
- Fix 'mon with Flying in type3 but not type1 or type2 is set to uninitialized roostTypes. - Remove unread third roostTypes element. - Option for Gen IV pure-Flying behavior.
mrgriffin
force-pushed
the
rhh-setroost-cleanup
branch
from
1d54fcc
to
632ec92
Compare
AsparagusEduardo
approved these changes
Dec 21, 2022
ghoulslash
reviewed
Jan 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type3but nottype1ortype2is set to uninitializedroostTypes.roostTypeselement.B_ROOST_PURE_FLYING).The bug is currently theoretical because there's no move that sets
type3toTYPE_FLYING, but it would allow a player to Roost with a Flying-type and later Roost with a Flying-type3, and at the end of the turn the second Pokémon would change to the types of the first.