-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert a few various to callnatives #2465
convert a few various to callnatives #2465
Conversation
Please fix conflicts. |
Please solve conflicts. |
Done |
I know this was introduced later, but we should use |
Also, instead of increasing EDIT: I know they're not arbitrary per se, but still. Is it not possible to do that in these cases? |
This is part of what I mean by using |
good call. just updated with them. The SetZEffect one still uses the old method but is a special case. would probably need a separate PR to clean it up if we wanted to down the line. |
ready for review |
Convert the following various to callnatives