Optimized Intimidate's code #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoulslash
requested changes
Dec 11, 2022
ghoulslash
requested changes
Dec 12, 2022
…AdrenalineOrb's demands
| @@ -158,7 +158,6 @@ struct SpecialStatus | |||
| u8 statLowered:1; | |||
| u8 lightningRodRedirected:1; | |||
| u8 restoredBattlerSprite: 1; | |||
| u8 intimidatedMon:1; | |||
There was a problem hiding this comment.
Forgot to submit this comment that I had pending:
Change to an unused name variation, as there's
// End of bytebelow.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remember how I optimized Bad Dreams a few days ago (#2434) and mentioned how Intimidate was similarly complex even though it didn't need to?
I decided to fix that because I wanted to so that's another battle script command freed to use moving forward.
As far as I tested, everything's working normally, but more tests are always welcomed.
Before:
https://user-images.githubusercontent.com/4485172/201494549-5f1e810f-95a5-4a27-ab8c-d73297852b49.mp4
After (this PR):
https://user-images.githubusercontent.com/4485172/201494560-f1a46ee3-8627-4d54-8ab3-73cb0b1c71d4.mp4
"But... doesn't that look exactly the same?"
I know! Isn't it awesome? Less code to deal with which means manipulating or copying Intimidate is super easy now!
Discord contact info
Lunos#4026