Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ACE_POKEMON_FUNCTIONALITY #2334

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Fixed ACE_POKEMON_FUNCTIONALITY #2334

merged 3 commits into from
Sep 18, 2022

Conversation

DarkCrobat
Copy link

@DarkCrobat DarkCrobat commented Sep 17, 2022 •
edited by AsparagusEduardo
Loading

EDITED by @AsparagusEduardo:

Original description

Removed ACE_POKEMON_FUNCTIONALITY.

For some reason, if this AI Flag was not turned on, this skipped over the functionality of choosing the next pokemon inline.
Functionality works when this flag is enabled, but not when it is not...?

Removing functionality for now. I will fix it with another pull request.

@AsparagusEduardo
Copy link
Collaborator

We should first try to fix it before removing it. It's not good looking leaving commented out code like this

AsparagusEduardo
AsparagusEduardo requested changes Sep 18, 2022
View reviewed changes
include/constants/battle_ai.h Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_ai_switch_items.c Outdated Show resolved Hide resolved
src/battle_controller_opponent.c Outdated Show resolved Hide resolved
src/battle_controller_opponent.c Outdated Show resolved Hide resolved
@AsparagusEduardo AsparagusEduardo changed the title Remove ACE_POKEMON_FUNCTIONALITY Fixed ACE_POKEMON_FUNCTIONALITY Sep 18, 2022
@AsparagusEduardo AsparagusEduardo merged commit 2c287b7 into rh-hideout:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Critical] Trainer parties are currently broken.
2 participants
@DarkCrobat @AsparagusEduardo