Inclusion of the tx_debug_system #2277

TheXaman · 2022-08-30T14:47:16Z

Description

Merged the debug menu into the master, added preproc directives TX_DEBUG_SYSTEM to enable/disable the debugging, located in debug.h.
Any additional suggestions for better rhh compatibility are welcome.

Discord contact info

TheXaman#5612

…rewrite and tons of additions V2: Fly, Warp, Flags, Vars, give items, give pkm 2 versions Improved cheats, reworked the vars system vars function now starts at VARS_START and end VARS_END Figured out how to display FieldMessages, reimplemented CheckSafeBlock, cleanup DebugAction_DestroyExtraWindow instead of multiple, renamed text variables cleanup + pokemon simple give pokemon complex nearly done Complex pkm works, items now with icons if statement cleanup alter build tools to include maps per map group Warp functionallity added hex value to flags and vars cleanup Credits

…pokeemerald_openworld into tx_debug_system

… ghoulslash

…pokeemerald_openworld into tx_debug_system

…s including hidden when using PE Give all TMs, watch credits, change trainer name/gender/id implemented moves

Thanks to Expo

…hanks to "Subzero Eclipse" for pointing it out

…or reaching out

@Sierraffinity

Toggle running shoes, Poison all mons, Max money, Max coins, Trigger daycare egg, Fill PC CREDITS: @Sierraffinity

… finding it

@Lunos

… to @Lunos for reporting

…econd ability was ABILITY_NONE, thanks to Syreldar

…debug_system

LOuroboros · 2022-08-30T15:48:42Z

As for the flags, they should probably be handled like the one for double battles inside include/constants/battle_config.h imo. That way we won't force the flags used onto the user and they can freely choose which ones to use on their own eyes

Changed the location to include/constants/battle_config.h, but I left the same unused flags as default, otherwise I expect there will be "bug reports" that some features of the new debug menu dont even work etc

I don't think that's a good place to put them in? This is a general debug menu after all. It has no place in a file to configure battle related mechanics.

A new include/constants/debug_config.h file would be nicer and be consistent not only with Pret's repository which normally put constant labels in that folder path, but also with the other configs that this project uses.

TheXaman · 2022-08-30T15:52:27Z

As for the flags, they should probably be handled like the one for double battles inside include/constants/battle_config.h imo. That way we won't force the flags used onto the user and they can freely choose which ones to use on their own eyes

Changed the location to include/constants/battle_config.h, but I left the same unused flags as default, otherwise I expect there will be "bug reports" that some features of the new debug menu dont even work etc

I don't think that's a good place to put them in? This is a general debug menu after all. It has no place in a file to configure battle related mechanics.

A new include/constants/debug_config.h file would be nicer and be consistent not only with Pret's repository which normally put constant labels in that folder path, but also with the other configs that this project uses.

Oh true, you said "like", I overread that, gonna change it

…file 'constants/debug_config.h'

data/scripts/debug.inc

include/constants/map_groups.h

src/start_menu.c

src/trainer_see.c

tools/mapjson/mapjson.cpp

include/constants/debug_config.h

include/constants/flags.h

…ed accidental type hin removal, changed indentation

changed no bag use and no catching flags to battle_config.h, removed TX reference (big sad)

…uires them is used

include/constants/battle_config.h

src/item_use.c

data/scripts/debug.inc

include/constants/overworld_config.h

src/field_control_avatar.c

src/debug.c

src/trainer_see.c

src/item_use.c

src/battle_main.c

src/debug.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

…ains

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

…e()'

src/item_use.c

TheXaman and others added 30 commits October 20, 2020 20:37

Merge branch 'tx_debug_system_public' of https://github.com/TheXaman/…

e6ab312

…pokeemerald_openworld into tx_debug_system

removed ability

c031099

Fixed the wrong palettes for the mon icons with the help of Nadia and…

6988864

… ghoulslash

Merge branch 'tx_debug_system_public' of https://github.com/TheXaman/…

b807a6d

…pokeemerald_openworld into tx_debug_system

Fixed forgotten PokemonSimple, thx to AsparagusEduardo

d380932

Added moves, trainer edits and fixed abilities, now only possible one…

6422164

…s including hidden when using PE Give all TMs, watch credits, change trainer name/gender/id implemented moves

Add debug makefile targets (#2)

549381f

Thanks to Expo

added individual IVs and reworked how data is stored to a struct

174867c

now closes debug windows after giving all TMs

5bb92ef

fixed heal party bug, thanks to jaizu for poitning it out

edc476f

Fixed problems with changed Deoxys handling in RHH's pokeexpansion, t…

c15138f

…hanks to "Subzero Eclipse" for pointing it out

WIP reset makefile to new default

27a9932

Added newest Makefile and fixed making from clean

965bcfa

Fixed setting vars not working, thanks to AmbientDinosaur and BSBob f…

40ebd66

…or reaching out

Fixed "new trainer id" option, thanks to Lunos and Deokishisu

c8c81e4

Added:

19cf846

Toggle running shoes, Poison all mons, Max money, Max coins, Trigger daycare egg, Fill PC CREDITS: @Sierraffinity

Formatting

822a6c4

Fixed bug not beeing able to select last species, thanks to Lunos for…

c92c345

… finding it

Small change to hidden ability (#3)

4e98c26

Added menu to run custom scripts easily, credit: @Jaizu

20ca83b

fixed credit link

9708ee0

Added Sound menu for SE and MUS

defd7d9

added SE and MUS names

81d7986

fixed some songs not properly stopping and overlapping others, thanks…

010c1b5

… to @Lunos for reporting

fixes PlaySE overwriting some "music tracks" like MUS_MOVE_DELETED

45012a6

fixed a bug not showing hidden abilities (POKEMON_EXPANSION) if the s…

a663742

…econd ability was ABILITY_NONE, thanks to Syreldar

added Debug to StartMenu via DEBUG_MENU option

af355fc

Changed to TX_DEBUGGING define instead of makefile DEBUGGING option

5104293

Merge branch 'master' of https://github.com/pret/pokeemerald into tx_…

2f8896f

…debug_system

TheXaman added 2 commits August 30, 2022 18:02

changed the locations of tx_debug_system related #defines to its own …

3debf04

…file 'constants/debug_config.h'

simplified filed controls code for debug menu

c13561e

AsparagusEduardo requested changes Aug 31, 2022

View reviewed changes

TheXaman added 4 commits September 2, 2022 12:10

removed unnecessary script, cheat start now with national dex, revert…

ad57551

…ed accidental type hin removal, changed indentation

changed debug_config.h to overworld_config.h,

367b128

changed no bag use and no catching flags to battle_config.h, removed TX reference (big sad)

removed default flags and added ingame warning if a function that req…

b4b3e84

…uires them is used

whitspace changes, removed wrong comment

13cc640

AsparagusEduardo requested changes Sep 3, 2022

View reviewed changes

AsparagusEduardo requested changes Sep 4, 2022

View reviewed changes

src/trainer_see.c Outdated Show resolved Hide resolved

src/item_use.c Outdated Show resolved Hide resolved

AsparagusEduardo reviewed Sep 4, 2022

View reviewed changes

src/battle_main.c Outdated Show resolved Hide resolved

AsparagusEduardo reviewed Sep 4, 2022

View reviewed changes

src/debug.c Outdated Show resolved Hide resolved

AsparagusEduardo added 2 commits September 3, 2022 21:22

Apply style suggestions from code review

4017fc3

Fixed call to ItemIdToBattleMoveId

1287c3d

AsparagusEduardo mentioned this pull request Sep 4, 2022

Include mGBA Printf to help debugging #2292

Closed

TheXaman and others added 9 commits September 5, 2022 11:02

Update include/constants/overworld_config.h

6cab795

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

Update src/field_control_avatar.c

0b3eddc

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

Update src/field_control_avatar.c

57296dd

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

Update src/trainer_see.c

7696a78

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

removed music expansion songs, added newline, removed all weekday rem…

40e3379

…ains

Update src/debug.c

f6d111d

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

changed 'B_FLAG_NO_CATCHING' to be evaluated by 'GetBallThrowableStat…

b249399

…e()'

fix?

94995c5

Merge branch 'master' into tx_debug_system_rhh

6062cf4

TheXaman requested a review from AsparagusEduardo September 6, 2022 23:12

AsparagusEduardo reviewed Sep 8, 2022

View reviewed changes

src/item_use.c Outdated Show resolved Hide resolved

Whitespace

4a6d3d1

AsparagusEduardo approved these changes Sep 8, 2022

View reviewed changes

AsparagusEduardo merged commit 066a5be into rh-hideout:master Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inclusion of the tx_debug_system #2277

Inclusion of the tx_debug_system #2277

TheXaman commented Aug 30, 2022

LOuroboros commented Aug 30, 2022

TheXaman commented Aug 30, 2022

Inclusion of the tx_debug_system #2277

Inclusion of the tx_debug_system #2277

Conversation

TheXaman commented Aug 30, 2022

Description

Discord contact info

LOuroboros commented Aug 30, 2022

TheXaman commented Aug 30, 2022