Triple kick power calc rework #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I broke stuff |
|
Reverted the removal of tripleKickPower and instead renamed it to unused, at least until someone can figure out how to safely remove it. |
|
Removed everything except the actual power calculation |
AsparagusEduardo
added
category: battle-mechanic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, moves that use EFFECT_TRIPLE_KICK deal too much damage. This can be fixed by just changing a "+=" to "=" in battle_util.c.
However, the battle script for this effect has some hard coded checks to find out what the base power of the move should be and utilizes a global when there is really no need to.
I decided to change it into a more flexible form that simply uses the move's base power and multiplies it based on the number of hits.