ABILITY_SYMBIOSIS

[AgustinGDLV]

Addresses issue #346. Lots of testing done, some of it below, a lot of it recorded and some of those recordings below, too. All major issues so far resolved! I may go back and try to combine trysymbiosis with the new MOVEEND_EFFECT which was implemented after to fix some other issues, but I'm not sure how simple that would be. If it would be best to merge the two, let me know.

Issues:

• Gem interactions unknown, but presumably they function like Focus Sash and the like.
• Bestow gets cut off early when Symbiosis procs.
• If an ally eats a foe's berry with Bug Bite but it has no effect (e.g. Sitrus Berry on max HP), Symbiosis does not proc.
• Fling is completely busted.
• Eject Button and Eject Pack incorrectly trigger Symbiosis. Need to test in IE, wasn't working because of debug mode.
• Message bug with damage-reducing berries (new item is received before message appears).

Tested Interactions:

• Red Card
• Focus Sash
• Bug Bite (all cases!)
• Knock Off
• Incinerate
• Air Balloon
• Trick
• Eject Button / Pack
• Gems
• Unexchangeable Items
• Fling
• Natural Gift
• Damage-reducing Berries
• Multiple Symbiosis abilities on side
• Gem behavior differences in Gen 6 and Gen 7+

Extra Demos:

show:

Bug Bite:

Focus Sash:

Incinerate:

Knock Off:

Red Card:

Gen 6 Gems:

Gen 7 Gems:

Eject Pack:

Discord Contact Info

Agustin#1522

[AgustinGDLV]

New commit. Other than some major issues with Fling, Symbiosis is accurate and functional in an isolated BE branch. More testing required with items from IE.

[AgustinGDLV]

Final commit? Tested most interactions and whatever edge cases I could think of. Gems and damage-reducing berries now function correctly (using a new MOVEEND effect), as do Eject Pack and Eject Button. Added battle config for gem function. I think this is complete!

[ghoulslash]

fix conflicts