Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Gen 5 & 6 mon animations from Inclement Emerald + added most missing Gen 7 form animations #1927

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Ported mon animations from Inclement Emerald (originally by Mr. Dollsteak) and also added most animations for Gen 7 forms. Only missing Oricorio, Lycanroc, Wishiwashi and Necrozma Forms

Discord contact info

AsparagusEduardo#6051

BuffelSaft and others added 3 commits November 21, 2021 11:28
Add animation data provided by Mr. Dollsteak for all gen 1-6 Pokémon (barring megas).
@AsparagusEduardo AsparagusEduardo added the category: pokemon Pertains to Pokémon data and functionality label Nov 21, 2021
@DizzyEggg
Copy link
Collaborator

I see this also changes the existing animations. Is that fine with everyone?

@BuffelSaft
Copy link
Collaborator

BuffelSaft commented Feb 13, 2022

I see this also changes the existing animations. Is that fine with everyone?

Super slow reply here, but it's fine with me. A lot of the existing animations look pretty bad with the new sprites (e.g. flappy arms Gardevoir). IMO Mr. Dollsteak's animations are really well done, they're a huge upgrade over the current ones.

@LOuroboros
Copy link
Collaborator

A few examples in a gif or a vid to illustraste would probably make it easier to decide, maybe? 👀

@AsparagusEduardo
Copy link
Collaborator Author

A few examples in a gif or a vid to illustraste would probably make it easier to decide, maybe? 👀

Alright, I'll do them

@AsparagusEduardo AsparagusEduardo changed the base branch from pokemon_expansion to master August 24, 2022 04:38
@DizzyEggg
Copy link
Collaborator

Alright, I'll do them

Waiting 😂

@AsparagusEduardo
Copy link
Collaborator Author

Alright, I'll do them

Waiting joy

Right! 😂

@AsparagusEduardo
Copy link
Collaborator Author

Old vs New (Gen 1-3)
006_old 006new
045_old 045new
086_old 086new
125_old 125new
153_old 153new
154_old 154new
157_old 157new
166_old 166new
180_old 180new
182_old 182new
183_old 183new
184_old 184new
191_old 191new
202_old 202new
203_old 203new
208_old 208new
214_old 214new
215_old 215new
223_old 223new
225_old 225new
227_old 227new
228_old 228new
232_old 232new
238_old 238new
239_old 239new
240_old 240new
242_old 242new
243_old 243new
248_old 248new
249_old 249new
282_old 282new

@LOuroboros
Copy link
Collaborator

Most of them look nice, but a few of the new ones look kinda weird or worse than the old ones imo. Namely: Electabuzz, Meganium, Azumarill, Raikou and Lugia.

@AsparagusEduardo
Copy link
Collaborator Author

Gen 4 (pt 1, for some reason I can't upload more files)

Old vs New
387_old 387new
388_old 388new
389_old 389new
390_old 390new
391_old 391new
392_old 392new
394_old 394new
395_old 395new
396_old 396new
397_old 397new
398_old 398new
399_old 399new
400_old 400new
401_old 401new
402_old 402new
403_old 403new
404_old 404new

@AsparagusEduardo
Copy link
Collaborator Author

AsparagusEduardo commented Sep 9, 2022

Gen 4 Pt 2
Old vs New
405_old 405new
406_old 406new
407_old 407new
408_old 408new
409_old 409new
410_old 410new
411_old 411new
412_old 412new
413_old 413new
416_old 416new
417_old 417new
418_old 418new
419_old 419new
420_old 420new
421_old 421new
422_old 422new
423_old 423new
424_old 424new
425_old 425new
426_old 426new
427_old 427new
428_old 428new
429_old 429new
430_old 430new
431_old 431new
432_old 432new
433_old 433new
434_old 434new
435_old 435new
436_old 436new
437_old 437new
438_old 438new
439_old 439new
440_old 440new
441_old 441new
442_old 442new
443_old 443new
444_old 444new
445_old 445new
446_old 446new
447_old 447new
448_old 448new
449_old 449new
450_old 450new
451_old 451new
452_old 452new
453_old 453new
454_old 454new
455_old 455new

@AsparagusEduardo
Copy link
Collaborator Author

Final part of Gen 4.

I'm not posting Gen 5-7 as those have default animations and can be viewed by checking out the PR.

456_old 456new
457_old 457new
458_old 458new
459_old 459new
460_old 460new
461_old 461new
462_old 462new
463_old 463new
464_old 464new
465_old 465new
466_old 466new
468_old 468new
469_old 469new
470_old 470new
471_old 471new
472_old 472new
473_old 473new
474_old 474new
475_old 475new
476_old 476new
477_old 477new
478_old 478new
479_fan_old 479_fannew
479_frost_old 479_frostnew
479_heat_old 479_heatnew
479_mow_old 479_mownew
479_normal_old 479_normalnew
479_wash_old 479_washnew
480_old 480new
481_old 481new
482_old 482new
483_old 483new
484_old 484new
485_old 485new
486_old 486new
487_old 487new
488_old 488new
489_old 489new
490_old 490new
491_old 491new
492_old 492new
493_old 493new

@AsparagusEduardo AsparagusEduardo changed the base branch from master to dev September 10, 2022 01:36
@AsparagusEduardo AsparagusEduardo changed the base branch from dev to dev_1.x September 16, 2022 17:34
…e/monAnimations

# Conflicts:
#	src/data/pokemon_graphics/front_pic_anims.h
#	src/pokemon.c
@AsparagusEduardo
Copy link
Collaborator Author

Fixed conflicts.

@ghoulslash ghoulslash merged commit f3d44f0 into rh-hideout:upcoming Nov 4, 2022
@AsparagusEduardo AsparagusEduardo deleted the PE_monAnimations branch November 4, 2022 15:01
@AsparagusEduardo AsparagusEduardo mentioned this pull request Nov 10, 2022
AsparagusEduardo pushed a commit that referenced this pull request Sep 26, 2023
Add Missing Constant Usage in m4a_1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants