Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont have XX_UP_HIT effects trigger at end of battle #1862

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

ghoulslash
Copy link
Collaborator

Addresses #1857

speedup-hit

Fell stinger is already handled in VARIOUS_TRY_ACTIVATE_FELL_STINGER

Technically, this will stop any MOVE_EFFECT_xx_PLUS_1 from occurring at the end of battle, although I can't think of a situation that wouldn't be desired. It is currently NOT applied to MOVE_EFFECT_xx_PLUS_2 because there are no relevant cases to consider.

@ghoulslash ghoulslash added bug Bug category: battle-mechanic Pertains to battle mechanics labels Nov 4, 2021
@ghoulslash ghoulslash linked an issue Nov 4, 2021 that may be closed by this pull request
@ghoulslash ghoulslash changed the title Dont XX_UP_HIT effects triggering at end of battle Dont have XX_UP_HIT effects trigger at end of battle Nov 5, 2021
@BuffelSaft
Copy link
Collaborator

I think a check for MOVE_EFFECT_xx_PLUS_2 is needed for Diamond Storm, but no issues otherwise.

@ghoulslash
Copy link
Collaborator Author

I think a check for MOVE_EFFECT_xx_PLUS_2 is needed for Diamond Storm, but no issues otherwise.

fixed!

@BuffelSaft BuffelSaft merged commit 5ac465b into rh-hideout:battle_engine Nov 8, 2021
@ghoulslash ghoulslash deleted the be/speeduphit branch November 8, 2021 12:32
AsparagusEduardo pushed a commit that referenced this pull request Mar 3, 2023
Fix spelling mistake for item flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFFECT_SPEED_UP_HIT raises speed when KO'ing the last mon in a party
2 participants