Refactor Form Change Table Code #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultima-soul
added
category: pokemon
This was referenced Oct 2, 2021
ultima-soul
force-pushed
the
form_change_table_fixes
branch
from
d6669d2
to
e72ff81
Compare
ExpoSeed
previously approved these changes
Oct 3, 2021
…cks into their own methods. Change FORM_ITEM_USE_TIME to specify time of day instead of hardcoding.
ultima-soul
force-pushed
the
form_change_table_fixes
branch
from
e72ff81
to
78d2215
Compare
ExpoSeed
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors some form change code and as a bonus improvement, added animation for the form change to be reminiscent of official games.
Ability checks now are separated into their own form change method and
FORM_ITEM_USE_DAYwas changed to allow forparam2to be used as an argument for time of day.As part of the refactor, there will need to be a companion PR to the Item Expansion that assigns the
FORM_ITEM_USEvariants of form change constants to thesecondaryIdfor the relevant items. This will allow for knowing whichFORM_ITEM_USEmethod to check for in theGetFormChangeTargetSpeciescall.Discord contact info
UltimaSoul#4017