Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relic Song form change happens at the wrong time #2040

Closed
AsparagusEduardo opened this issue Jan 21, 2022 · 9 comments
Closed

Relic Song form change happens at the wrong time #2040

AsparagusEduardo opened this issue Jan 21, 2022 · 9 comments

Comments

@AsparagusEduardo
Copy link
Collaborator

When reviewing #1734 , I noticed that the edge case of Meloetta with Magician didn't work properly because Meloetta's transformation is happening before any other event, including fainting and triggering of abilities like Magician.

pn_16012022_2310915.mp4

@BLourenco
Copy link

relic-song-bug
The transformation doesn't just happen before every event, but it also triggers after each foe that's hit.

@AlexOn1ine
Copy link
Collaborator

Should the Magician interaction be tested? Meloetta doesn't have the ability

@AlexOn1ine
Copy link
Collaborator

@AsparagusEduardo Do you want to test this? It should be fixed in #3476

@AsparagusEduardo
Copy link
Collaborator Author

@AsparagusEduardo Do you want to test this? It should be fixed in #3476

Sure, give me a sec.

@AsparagusEduardo
Copy link
Collaborator Author

Issue fixed :D
mGBA_92T9Ll69aJ

Can you make a test for this edge case? ^^;

@AlexOn1ine
Copy link
Collaborator

Issue fixed :D mGBA_92T9Ll69aJ mGBA_92T9Ll69aJ

Can you make a test for this edge case? ^^;

I would but I'm not sure how we feel about illegal abilities.

@AsparagusEduardo
Copy link
Collaborator Author

I would but I'm not sure how we feel about illegal abilities.

Skill Swap maybe? It's the only legimitate way this edge case would manifest anyway 👀

@AlexOn1ine
Copy link
Collaborator

I would but I'm not sure how we feel about illegal abilities.

Skill Swap maybe? It's the only legimitate way this edge case would manifest anyway 👀

Right. I always forget Skill Swap exists lol

@Bassoonian
Copy link
Collaborator

Fixed by #3583

Bassoonian pushed a commit that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants