Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wish is broken #1915

Closed
BuffelSaft opened this issue Nov 18, 2021 · 1 comment · Fixed by #1924
Closed

Wish is broken #1915

BuffelSaft opened this issue Nov 18, 2021 · 1 comment · Fixed by #1924
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics category: move effect Pertains to move effects

Comments

@BuffelSaft
Copy link
Collaborator

Just had a report of wish restoring 1 HP when used by an Alomomola, and looking at the code I don't follow where it's getting the HP value to restore - shouldn't it be stored somewhere on use and then read when it heals? The whole point of the gen 5 mechanic is that the user can switch out and then the target will receive half of the user's max HP. Currently it's reading from a field that only includes mons that are in battle, so it's definitely not doing that.
@BuffelSaft BuffelSaft added bug Bug category: battle-mechanic Pertains to battle mechanics category: move effect Pertains to move effects labels Nov 18, 2021
@ghoulslash ghoulslash mentioned this issue Nov 20, 2021
Merged
@ghoulslash ghoulslash linked a pull request Nov 20, 2021 that will close this issue
Fix wish #1924
Merged
@ghoulslash
Copy link
Collaborator

#1924

halabi232 pushed a commit to halabi232/Pokemon-NeoYellow that referenced this issue Oct 23, 2023
@GriffinRichards
Merge pull request rh-hideout#1915 from GriffinRichards/misc-tasks
104e81b 
Add some task/sprite data defines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics category: move effect Pertains to move effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wish ghoulslash/pokeemerald
2 participants
@BuffelSaft @ghoulslash