Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storm Drain, Sap Sipper etc. don't work properly with multi-hit moves #1814

Closed
BuffelSaft opened this issue Oct 26, 2021 · 1 comment
Closed

Storm Drain, Sap Sipper etc. don't work properly with multi-hit moves #1814

BuffelSaft opened this issue Oct 26, 2021 · 1 comment
Labels
bug Bug category: ability Pertains to abilities category: battle-mechanic Pertains to battle mechanics status: confirmed This bug has been confirmed to exist in the codebase

Comments

@BuffelSaft
Copy link
Collaborator

storm drain
Every hit of a multi hit attack should activate these abilities. This behaves differently in #1676 (the first hit activates the ability and the rest ignore it). I think fixing this is going to require moving the trigger for these abilities somewhere else.
@BuffelSaft BuffelSaft added bug Bug category: battle-mechanic Pertains to battle mechanics status: confirmed This bug has been confirmed to exist in the codebase category: ability Pertains to abilities labels Oct 26, 2021
@BuffelSaft
Copy link
Collaborator Author

Never mind, this is actually working correctly. Only abilities that don't negate the move can activate multi times (e.g. water compaction).

AsparagusEduardo pushed a commit that referenced this issue Nov 9, 2022
@GriffinRichards
Merge pull request #1814 from AsparagusEduardo/pret/pr/storageDoc
0a6de12 
Doc missing uses of ST_OAM_OBJ_X in Pokémon Storage System
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: ability Pertains to abilities category: battle-mechanic Pertains to battle mechanics status: confirmed This bug has been confirmed to exist in the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BuffelSaft