Skip to content

fix: port leftover 1817/1829 deltas after PR 1941 - #2018

Open
sebrandon1 wants to merge 1 commit into
rh-ecosystem-edge:mainfrom
sebrandon1:fix/leftover-1817-1829-deltas
Open

sebrandon1 wants to merge 1 commit into
rh-ecosystem-edge:mainfrom
sebrandon1:fix/leftover-1817-1829-deltas

Conversation

@sebrandon1

@sebrandon1 sebrandon1 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Port remaining leftovers from closed #1817 / #1829 that were not included when #1941 merged the Ed25519 + P-384 product code
  • Strengthen integration with e2e-unique crypto coverage (prefer integration over growing e2e)
  • Document e2e vs integration in root README + tests/integration/README.md

Ref: CNF-25515, CNF-26736

Integration tests added / updated

Scenario Coverage
test_crypto_ecdsa_p384 (via helpers) Re-enable P-384 openssl verify chain check
test_crypto_jwt_rs256 / es256 / es384 / eddsa Multi-alg JWT resign + verify (run_jwt_algo_test)
test_crypto_ed25519 Ed25519 CA+leaf regen + chain verify (replaces misleading *_rejected)
test_crypto_standalone_keys Standalone .key/.pub (RSA PUBLIC KEY + SPKI)

E2E

  • Light CI harden only: on failure, upload e2e-failure/ (crypto dir + stderr)
  • No Docker/etcd in e2e

Test plan

  • cargo test in Docker rust:1.87
  • CI rust-ci / cargo-* green
  • Integration / e2e green with new scenarios

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 83a4f9f2-484b-45ec-849e-8b468d99dfd8


Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from danmanor and tsorya September 18, 2026 14:30
@sebrandon1
sebrandon1 force-pushed the fix/leftover-1817-1829-deltas branch 4 times, most recently from d8a1c6f to 75794d1 Compare September 21, 2026 16:09
@sebrandon1

Copy link
Copy Markdown
Contributor Author

/retest

@red-hat-konflux

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@omertuc

omertuc commented Sep 22, 2026

Copy link
Copy Markdown
Member

/lgtm

@omertuc

omertuc commented Sep 22, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
sebrandon1 force-pushed the fix/leftover-1817-1829-deltas branch from 75794d1 to c3fb0c7 Compare September 23, 2026 14:24
@openshift-ci openshift-ci Bot removed the lgtm label Sep 23, 2026
@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@sebrandon1
sebrandon1 force-pushed the fix/leftover-1817-1829-deltas branch 2 times, most recently from 57fdbe1 to f2a69a4 Compare September 23, 2026 14:47
@sebrandon1
sebrandon1 force-pushed the fix/leftover-1817-1829-deltas branch from f2a69a4 to c288bea Compare September 23, 2026 14:58
@sebrandon1

Copy link
Copy Markdown
Contributor Author

/retest

@red-hat-konflux

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ipc-e2e-flow c288bea link true /test ipc-e2e-flow
ci/prow/e2e-aws-ovn-single-node-recert-serial c288bea link true /test e2e-aws-ovn-single-node-recert-serial
ci/prow/e2e-aws-ovn-single-node-recert-parallel c288bea link true /test e2e-aws-ovn-single-node-recert-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@omertuc

omertuc commented Sep 24, 2026

Copy link
Copy Markdown
Member

 /test ipc-e2e-flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants