eval: update script as per latest lsc logic #69

asamal4 · 2025-07-28T12:29:45Z

Remove additional print statements (now added in LSC-Eval)
Update method names
Use summary result from lsc
minor refactoring

Summary by CodeRabbit

Chores
- Updated .gitignore to exclude files and folders starting with eval_output.
Documentation
- Revised evaluation README to update setup instructions and reorder supported evaluation types. Simplified test output section.
Refactor
- Streamlined evaluation script for simpler execution and result reporting, delegating more logic to the evaluation manager and improving output handling.

coderabbitai · 2025-07-28T12:29:52Z

Walkthrough

The .gitignore file was updated to ignore files and directories starting with eval_output. The test/evals/README.md documentation was revised to update references, reorder evaluation types, and remove a large example output section. The test/evals/eval.py script was refactored to centralize evaluation execution and result summarization, simplifying its control flow.

Changes

Cohort / File(s)	Change Summary
Git Ignore Update `.gitignore`	Added pattern to ignore files/directories starting with `eval_output`.
Evaluation Script Refactor `test/evals/eval.py`	Refactored script to delegate evaluation execution and result summarization to `AgentGoalEval`, removed manual iteration and result printing, updated output directory argument, and simplified control flow.
Evaluation Documentation `test/evals/README.md`	Updated references, reordered supported evaluation types, and removed example output section from documentation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant eval.py
    participant AgentGoalEval

    User->>eval.py: Run evaluation script
    eval.py->>AgentGoalEval: run_evaluation()
    AgentGoalEval-->>eval.py: [results]
    eval.py->>AgentGoalEval: get_result_summary()
    AgentGoalEval-->>eval.py: summary dict
    alt Any failures
        eval.py->>User: Print failure message, exit 1
    else No failures
        eval.py->>User: Print success message, exit 0
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

MGMT-21148: Add initial eval tests #40: Introduced the original evaluation tests and script logic, which is directly refactored and simplified in this PR.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3c123d and d6750ae.

📒 Files selected for processing (3)

.gitignore (1 hunks)
test/evals/README.md (1 hunks)
test/evals/eval.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request

🔇 Additional comments (5)

.gitignore (1)

9-10: LGTM! Proper gitignore pattern for evaluation outputs.

The addition correctly ignores evaluation output directories with a clear explanatory comment. The pattern eval_output*/ properly matches directories starting with "eval_output" and aligns with the updated directory name in eval.py.

test/evals/README.md (1)

3-4: Documentation improvements align with script updates.

The updated reference to the LCORE-Eval repository provides clearer setup instructions, and the reordered evaluation types reflect the streamlined approach. The removal of verbose example outputs (mentioned in AI summary) is consistent with the simplified evaluation reporting in eval.py.

test/evals/eval.py (3)

1-18: Clean imports and logging configuration.

The formatting improvements and logging setup are well-structured. The logging configuration appropriately sets WARNING level globally while enabling INFO level for the specific lsc_agent_eval logger.

21-30: Configuration setup looks comprehensive.

The argument namespace setup covers all necessary parameters for the evaluation. The change from "results" to "eval_output" aligns with the .gitignore update and provides clearer naming.

32-44: Excellent refactoring to delegate evaluation management.

The simplification from manual evaluation iteration to using AgentGoalEval's built-in methods is a significant improvement:

run_evaluation() handles the complex evaluation logic

get_result_summary() provides structured results

Proper error handling by combining "FAIL" and "ERROR" counts

Clear success/failure messaging with appropriate exit codes

This aligns perfectly with the PR objectives of utilizing LSC summary results and removing manual print statements.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-ci · 2025-07-28T17:58:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asamal4, carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

use print from latest lsc

d6750ae

openshift-ci bot requested review from eranco74 and omertuc July 28, 2025 12:29

asamal4 mentioned this pull request Jul 28, 2025

eval: update script as per latest lsc logic #55

Closed

carbonin approved these changes Jul 28, 2025

View reviewed changes

openshift-ci bot assigned carbonin Jul 28, 2025

openshift-ci bot added the lgtm label Jul 28, 2025

openshift-ci bot added the approved label Jul 28, 2025

openshift-merge-bot bot merged commit aa066dc into rh-ecosystem-edge:main Jul 28, 2025
5 checks passed

This was referenced Aug 11, 2025

MGMT-21239: creating an image which could be started in the cluster claimed by prow #109

Merged

eval: data model change for multi-eval #117

Merged

coderabbitai bot mentioned this pull request Aug 26, 2025

MGMT-20906: Re-enabling the evaluation tests. The eval test does not need to run in an openshift deployment #142

Merged

coderabbitai bot mentioned this pull request Sep 19, 2025

making the evaluation tests more stable #213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

eval: update script as per latest lsc logic #69

eval: update script as per latest lsc logic #69

Uh oh!

asamal4 commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

openshift-ci bot commented Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eval: update script as per latest lsc logic #69

eval: update script as per latest lsc logic #69

Uh oh!

Conversation

asamal4 commented Jul 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

openshift-ci bot commented Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

asamal4 commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)