Use an older lightspeed stack tag #59
Conversation
The "dev-latest" tag was failing when we tried to run, but this tag matches the commit of our submodule and the patch applies cleanly
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughThe base image reference in the Containerfile for assisted-chat was updated from a floating "dev-latest" tag to a specific version tag "dev-20250718-0cb49fc". No other modifications to build instructions or configuration were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation - BetaCodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Containerfile.assisted-chat (1)
2-2: Pin by digest for full immutabilitySwitching from the floating
dev-latesttag to a date-stamped tag is a step forward, but tags can still be re-pushed. Consider pinning by SHA-256 digest to guarantee byte-for-byte reproducibility and prevent supply-chain surprises.-FROM quay.io/lightspeed-core/lightspeed-stack:dev-20250718-0cb49fc +FROM quay.io/lightspeed-core/lightspeed-stack@sha256:<digest_here> # dev-20250718-0cb49fc
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Containerfile.assisted-chat(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
🔇 Additional comments (1)
Containerfile.assisted-chat (1)
8-12: Ensure build fails if the llama-stack patch doesn’t apply cleanlyAdd strict error handling to the RUN step in Containerfile.assisted-chat (around lines 8–12) so the build will error out if the patch fails:
USER root -RUN microdnf install -y patch -RUN curl -L https://github.com/meta-llama/llama-stack/commit/5e18d4d097d683056174b3c8b270806326e7ee96.patch | patch -p1 -d $(dirname $(dirname $(python3 -c "import llama_stack; print(llama_stack.__file__)"))) +RUN set -euo pipefail && \ + microdnf install -y patch && \ + curl -fsSL https://github.com/meta-llama/llama-stack/commit/5e18d4d097d683056174b3c8b270806326e7ee96.patch \ + | patch -p1 -d "$(dirname "$(dirname "$(python3 - <<'PY' +import os, llama_stack +print(os.path.abspath(os.path.dirname(llama_stack.__file__))) +PY +)")")" USER 1001• Please verify the patch still applies cleanly against the current base image.
|
Adding lgtm manually since it's late for most of the team and nothing is working right now. |
openshift-merge-bot
bot
merged commit 57b791e
into
rh-ecosystem-edge:main
1 participant
The "dev-latest" tag was failing when we tried to run, but this tag matches the commit of our submodule and the patch applies cleanly
Summary by CodeRabbit