feat: Enhance system prompt for improved agent memory and workflow #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe system prompt configuration was updated to focus specifically on the OpenShift Assisted Installer, with expanded instructions for memory retention, proactive workflow guidance, and stepwise assistant behavior throughout the installation process. No code or exported entity changes were made; all modifications are limited to the prompt text. Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
|
/hold |
Collaborator
Author
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
config/systemprompt.txt (5)
1-1: Consistently capitalize “OpenShift”.Line 1 uses “Openshift” (lower-case “s”). Elsewhere the document uses the canonical “OpenShift”. Unify the product name to avoid brand inconsistency.
-You are Openshift Lightspeed Intelligent Assistant +You are OpenShift Lightspeed Intelligent Assistant
6-8: Numbering jumps from 2 → 4; insert the missing “3.”The ordered list under “Memory and Context Retention” skips the number 3, which can confuse readers and automatic parsers.
-2. **Internal Checklist Mentality:** … -4. **No Redundancy:** … +2. **Internal Checklist Mentality:** … +3. **No Redundancy:** … +4. **Unambiguous Action Triggering on Affirmation ("Yes") & Progression:** …(NOTE: increment subsequent numbers accordingly.)
9-11: Heading 5 now duplicates content after renumbering.After shifting numbers, the current item 5 becomes redundant with the new item 4. Consider merging or deleting to keep the list concise.
45-45: Remove duplicated word “the”.Minor typo hurts readability.
- * Proactively offer to provide the the ISO download URL. + * Proactively offer to provide the ISO download URL.
75-82: Trailing list lacks terminating period consistency.Some bullets end with periods, others don’t (e.g., lines 75–82). Pick one style (period or no-period) and apply consistently for professional polish.
Key improvements: * Enhanced Proactivity: The agent is now better instructed to anticipate user needs and guide them through the installation process more effectively. * Persistent Memory: The agent will now more reliably remember and use **all provided information**, including the **Cluster ID**, without re-asking. * Action-Oriented Affirmations: "Yes" responses to proposed actions will now explicitly trigger those actions and advance the workflow, preventing conversational loops. * Proactive ID Usage: The agent is instructed to automatically supply known identifiers for tool calls, streamlining interactions. Signed-off-by: Eran Cohen <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/systemprompt.txt (3)
3-4: Fix the broken bold-markdown delimiterThe sentence opens bold twice but closes it only once, so everything after “to” is rendered as normal text instead of bold. Move the closing
**to the end of the sentence:-**Your highest priority during this entire interaction is to **maintain precise awareness of the current stage of the OpenShift Assisted Installer workflow and to never ask for information the user has already provided or that is irrelevant to the current phase.** +**Your highest priority during this entire interaction is to maintain precise awareness of the current stage of the OpenShift Assisted Installer workflow and to never ask for information the user has already provided or that is irrelevant to the current phase.**
10-16: Remove the duplicated “unambiguous action triggering” guidelineBullet #3 and bullet #5 convey the same rule, creating noise and risking contradictory edits later. Consolidate them into a single bullet:
-3. **UNAMBIGUOUS ACTION TRIGGERING ON AFFIRMATION ("YES") & PROGRESSION (STAGE-SPECIFIC):** This is paramount. - * When you propose a specific action or a next step that requires user confirmation, a user's **"yes" response (or similar affirmation)** is an **IMMEDIATE, UNCONDITIONAL COMMAND TO PERFORM THAT *SPECIFIC PROPOSED ACTION*** and advance the workflow. - * Upon receiving "yes" to a proposed action, you **MUST NOT** re-summarize past information or re-ask questions. You **MUST immediately proceed to execute *only the proposed action*** (or acknowledge its completion) and transition to the next logical workflow stage. -... -5. **Unambiguous Action Triggering on Affirmation ("Yes") & Progression:** This is paramount. - * When you propose an action or a next step that requires user confirmation (e.g., "Do you want me to proceed with creating the cluster?", "Would you like me to provide the ISO download URL?"), a user's **"yes" response (or similar affirmation)** is an **immediate, unconditional command to perform that action and advance the workflow.** +3. **UNAMBIGUOUS ACTION TRIGGERING ON AFFIRMATION ("YES") & PROGRESSION (STAGE-SPECIFIC):** + * When you propose an action that needs confirmation, the user's **"yes"** (or similar) is an **immediate, unconditional command to execute exactly that action and move to the next workflow stage.** + * After “yes”, do **not** re-summarize prior info or re-ask questions—just perform the action and advance.
35-35: Consistent product spelling“Openshift” → “OpenShift” to match Red Hat branding used elsewhere in the prompt.
-You are Openshift Lightspeed Intelligent Assistant. +You are OpenShift Lightspeed Intelligent Assistant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key improvements:
Summary by CodeRabbit