feat: add conditional SSH key prompt

[eranco74]

Updated the system prompt workflow guidance to refine the post-cluster-creation user interaction flow:

1. Explicitly ordered the proactive prompts to ensure the Static Network Configuration reminder is presented to the user.
2. Add conditional SSH public key prompt. It will only be presented to the user if the key was not provided during the initial cluster creation request.
3. Evaluation tests were updated to reflect this new, expected response.

Summary by CodeRabbit

• New Features

  • Added an optional SSH key provisioning prompt after cluster creation for users who didn't provide a key during setup; static network reminder and discovery ISO checks remain.

• Chores

  • Removed several Gemini LLM entries from the available inference models, tightening the public model list.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removes three Gemini LLM entries from the inference configuration, adds a conditional SSH public-key prompt to the cluster-creation dialog that only appears if no key was provided during creation, and updates evaluation test data to expect the new prompt.

Changes

Cohort / File(s)	Change Summary
Model Configuration config/llama_stack_client_config.yaml	Deleted three Gemini LLM entries: gemini/gemini-2.0-flash, gemini/gemini-2.5-pro, gemini/gemini-2.5-flash from inference_store.models; retained existing embedding model entry.
Dialog Template template.yaml	Added a conditional SSH public-key prompt shown after cluster creation success when no SSH key was provided during creation; static network reminder and discovery ISO flow wording preserved.
Evaluation Test Data test/evals/eval_data.yaml	Updated multinode creation expected_response to include the new optional SSH key provisioning prompt following the DHCP/static network prompt.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review attention: config/llama_stack_client_config.yaml (ensure removed models don't break references), template.yaml (verify conditional rendering logic and phrasing), test/evals/eval_data.yaml (ensure expectations match template changes).

Possibly related PRs

• changing the prompt so the host_booted_but_not_discovered test would be more consistent #223 — Updates the same dialog flow files (template.yaml, test/evals/eval_data.yaml) and modifies prompts related to SSH/static-network steps.
• Updted the template to use the LLAMA_STACK_2_0_FLASH_MODEL as the default model #77 — Modifies the same model configuration area in config/llama_stack_client_config.yaml (model list changes).
• Add gemini-2.0-flash model to llama-stack config #28 — Previously added the gemini/gemini-2.0-flash model entry that this change removes.

Suggested labels

lgtm

Suggested reviewers

• jhernand
• omertuc
• carbonin

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: add conditional SSH key prompt' directly and clearly summarizes the main change across all modified files—adding a conditional SSH key prompt after cluster creation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10f2d2e and ce1dfe5.

📒 Files selected for processing (2)

• template.yaml (1 hunks)
• test/evals/eval_data.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• test/evals/eval_data.yaml
• template.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
• GitHub Check: Red Hat Konflux / assisted-chat-test-image-saas-main-on-pull-request

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea3ba7a and 26102d4.

📒 Files selected for processing (4)

• config/llama_stack_client_config.yaml (0 hunks)
• template.yaml (1 hunks)
• test/evals/eval_data.yaml (1 hunks)
• test/evals/eval_data_eran.yaml (1 hunks)

💤 Files with no reviewable changes (1)

• config/llama_stack_client_config.yaml

🔇 Additional comments (2)

template.yaml (1)

285-301: System prompt conditional SSH key prompt logic is clear and well-ordered.

The workflow guidance properly documents:

1. Static network configuration reminder (Line 289) – shown before offering Discovery ISO if no static config present
2. Conditional SSH key prompt (Line 290) – shown only if SSH key was not provided during cluster creation

The expected behavior correctly gates the SSH key prompt on whether a key was already provided, and the test evaluation data (eval_data.yaml) aligns with this logic. The ordering and conditions are sound.

test/evals/eval_data_eran.yaml (1)

1-7: New evaluation test for multi-cluster creation constraint is well-structured.

The test correctly validates the system's enforcement of the "single cluster creation only" constraint documented in the system prompt (template.yaml lines 240–241). The eval query and expected intent alignment are appropriate.

[carbonin]

Looks like there's some stuff in here that you didn't mean to commit

[openshift-ci]

@eranco74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/eval-test	ce1dfe5	link	false	/test eval-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [carbonin,eranco74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment