Skip to content

MGMT-21659: clarify conditions for starting the cluster install#242

Merged
zszabo-rh merged 1 commit intorh-ecosystem-edge:mainfrom
zszabo-rh:clarify_auto_start
Nov 18, 2025
Merged

MGMT-21659: clarify conditions for starting the cluster install#242
zszabo-rh merged 1 commit intorh-ecosystem-edge:mainfrom
zszabo-rh:clarify_auto_start

Conversation

@zszabo-rh
Copy link
Collaborator

@zszabo-rh zszabo-rh commented Nov 3, 2025

According to MGMT-21659 the chatbot occasionally claims that the installation is supposed to start automatically once the hosts have registered.

I wasn’t able to reproduce this behavior during my test conversations, but I added an extra instruction to the system prompt to ensure this response never occurs.

Summary by CodeRabbit

  • Documentation
    • Clarified installation flow to require explicit user initiation; removed any wording that could imply automatic start and now instructs showing a clear "ready to start installation" prompt before proceeding.
    • Updated guidance and user-facing messaging to ensure installers request and await user confirmation prior to beginning installation, improving safety and predictability.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025

@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

According to MGMT-21659 the chatbot occasionally claims that the installation is supposed to start automatically once the hosts have registered.

I wasn’t able to reproduce this behavior during my test conversations, but I added an extra instruction to the system prompt to ensure this response never occurs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from keitwb and omertuc November 3, 2025 12:16
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zszabo-rh
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

Added an explicit safety directive in template.yaml under the Initiate Installation step: installation must never start automatically and must be explicitly initiated by the user; wording changed to use phrases like "ready to start installation."

Changes

Cohort / File(s) Summary
Installation initiation safety guidance
template.yaml
Replaced any implication of automatic installation start with explicit guidance that installation never starts automatically and must be explicitly initiated by the user; updated phrasing to use "ready to start installation" style prompts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the revised phrasing unambiguously requires explicit user initiation.
  • Check consistency with other prompts or automation hooks that might imply auto-start.

Possibly related PRs

Suggested labels

lgtm, ok-to-test

Suggested reviewers

  • keitwb
  • omertuc

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'MGMT-21659: clarify conditions for starting the cluster install' directly relates to the main change in the changeset. The summary indicates the PR adds an explicit directive to ensure installation must never start automatically and must be explicitly initiated by the user. The title accurately captures this core intent—clarifying the conditions for starting the cluster install by removing ambiguity about automatic startup.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f45cd32 and d0777d6.

📒 Files selected for processing (1)
  • template.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • template.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025

@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

According to MGMT-21659 the chatbot occasionally claims that the installation is supposed to start automatically once the hosts have registered.

I wasn’t able to reproduce this behavior during my test conversations, but I added an extra instruction to the system prompt to ensure this response never occurs.

Summary by CodeRabbit

  • Documentation
  • Updated installation flow guidance to enforce explicit user-initiated startup, replacing automatic startup implications with clearer messaging that installation is ready to begin upon user action.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Collaborator

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a nit

template.yaml Outdated

5. **Initiate Installation:**
* Once the cluster is configured, hosts are discovered and assigned roles, and VIPs are set (if applicable), the final step is to **start the cluster installation**.
* **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated by the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated by the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically."
* **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated per the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically."

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025

@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

According to MGMT-21659 the chatbot occasionally claims that the installation is supposed to start automatically once the hosts have registered.

I wasn’t able to reproduce this behavior during my test conversations, but I added an extra instruction to the system prompt to ensure this response never occurs.

Summary by CodeRabbit

  • Documentation
  • Clarified installation flow to require explicit user initiation; removed any wording that could imply automatic start and now instructs showing a clear "ready to start installation" prompt before proceeding.
  • Updated guidance and user-facing messaging to ensure installers request and await user confirmation prior to beginning installation, improving safety and predictability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zszabo-rh
Copy link
Collaborator Author

/test eval-test

@zszabo-rh zszabo-rh requested a review from eranco74 November 4, 2025 09:34
Copy link
Collaborator

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2025
@zszabo-rh zszabo-rh merged commit a3d4978 into rh-ecosystem-edge:main Nov 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants