MGMT-21659: clarify conditions for starting the cluster install#242
Conversation
|
@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zszabo-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughAdded an explicit safety directive in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
template.yaml
Outdated
|
|
||
| 5. **Initiate Installation:** | ||
| * Once the cluster is configured, hosts are discovered and assigned roles, and VIPs are set (if applicable), the final step is to **start the cluster installation**. | ||
| * **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated by the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically." |
There was a problem hiding this comment.
| * **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated by the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically." | |
| * **CRITICAL: Installation NEVER starts automatically.** Installation must always be explicitly initiated per the user's request. Never claim that installation will begin automatically when hosts register, are discovered, or meet requirements. Use phrases like "ready to start installation" or "installation can now be initiated" instead of "installation will begin automatically." |
f45cd32 to
d0777d6
Compare
|
@zszabo-rh: This pull request references MGMT-21659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test eval-test |
According to MGMT-21659 the chatbot occasionally claims that the installation is supposed to start automatically once the hosts have registered.
I wasn’t able to reproduce this behavior during my test conversations, but I added an extra instruction to the system prompt to ensure this response never occurs.
Summary by CodeRabbit