Skip to content

Bump lightspeed version to 0.3.0#233

Merged
openshift-merge-bot[bot] merged 2 commits intorh-ecosystem-edge:mainfrom
eranco74:bump_lsc
Oct 21, 2025
Merged

Bump lightspeed version to 0.3.0#233
openshift-merge-bot[bot] merged 2 commits intorh-ecosystem-edge:mainfrom
eranco74:bump_lsc

Conversation

@eranco74
Copy link
Collaborator

@eranco74 eranco74 commented Oct 19, 2025

0.3.0 Release is using llama-stack 0.2.22
We no longer need the env var replacement patch (applied during the container file build) since it was merged to LLS v0.2.20.

Summary by CodeRabbit

  • Chores
    • Simplified container images and runtime setup for a leaner startup (removed prior patch workflow and redundant user switches; port 8080 exposed).
    • Updated base image references and refreshed submodule/infrastructure pointers for improved stability.
    • Removed the previously included RAG tool/runtime integration and its associated toolgroup configuration, streamlining available tooling and runtime surface.

@openshift-ci openshift-ci bot requested review from carbonin and omertuc October 19, 2025 12:49
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

Replaces in-image patching and USER switches by updating assisted-chat Containerfiles to a newer lightspeed-stack base image (removing patch-install/apply and root steps), removes rag-runtime/toolgroup entries from template.yaml, and updates lightspeed-stack and llama-stack submodule commits.

Changes

Cohort / File(s) Summary
Containerfile: runtime simplification
Containerfile.add_llama_to_lightspeed, Containerfile.assisted-chat
Updated FROM to quay.io/lightspeed-core/lightspeed-stack:0.3.0@sha..., removed patch installation and apply steps and USER root switches, retained USER 1001, and added EXPOSE 8080.
Submodule pointers
lightspeed-stack, llama-stack
Updated submodule commit references (lightspeed-stack from 3c0c98b2... to 5ad22fbe...; llama-stack subproject commit updated). No other submodule code changes in this diff.
Configuration: remove RAG runtime/toolgroup
template.yaml
Removed rag-runtime entry from tool_runtime and removed builtin::rag toolgroup and its top-level associations from llama-stack-client-config.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer / CI
  participant Build as Image build (Docker/BuildKit)
  participant Base as lightspeed-stack base image
  participant Runtime as Container runtime

  rect rgba(120,160,240,0.06)
  Dev->>Build: Trigger image build
  Build->>Base: FROM quay.io/lightspeed-core/lightspeed-stack:0.3.0@sha...
  note right of Base #e6f7ee: New base removes need for in-image patches
  Build-->>Runtime: Produce runtime image (USER 1001, EXPOSE 8080)
  end
Loading
sequenceDiagram
  participant BuildOld as Old image build
  participant Tools as Patch tooling (microdnf/patch)
  participant Patch as Remote patch fetch/apply

  rect rgba(240,200,140,0.06)
  BuildOld->>Tools: Install patch tooling (root)
  BuildOld->>Patch: Download & apply patch (root)
  Tools-->>BuildOld: Modify image layers
  BuildOld->>BuildOld: Switch back to USER 1001
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • omertuc
  • carbonin
  • jhernand

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Bump lightspeed version to 0.3.0" is fully related to the main change in the changeset. The PR objectives clearly state the primary goal is updating Lightspeed to version 0.3.0, and the changes across multiple files (Containerfile updates to the new base image, submodule updates, and configuration adjustments) all serve to implement this version bump. The title is clear, specific, and concise—it accurately conveys the core change without vague language or unnecessary noise, and a teammate scanning history would immediately understand this is a version update.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bec8fe4 and 655e157.

📒 Files selected for processing (1)
  • template.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • template.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Red Hat Konflux / assisted-chat-test-image-saas-main-on-pull-request
  • GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

/hold

@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

Forgot to bump the llama-stack submodule

0.3.0 Release is using llama-stack 0.2.22
We no longer need the env var replacement patch (applied during the container file build) since it was merged to LLS v0.2.20.
Bump llama-stack submodule to v0.2.22

Signed-off-by: Eran Cohen <eranco@redhat.com>

Signed-off-by: Eran Cohen <eranco@redhat.com>
@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

Closes #178

@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

/unhold

@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

/lgtm

@eranco74
Copy link
Collaborator Author

/retest

…'t use RAG and the current configuration is no longer valid

This resolves:
RuntimeError: Failed to resolve 'tool_runtime' provider 'rag-runtime' of type 'inline::rag-runtime': required dependency 'files' is not available. Please add a 'files' provider to your configuration or check if the provider is properly configured.

Signed-off-by: Eran Cohen <eranco@redhat.com>
@eranco74
Copy link
Collaborator Author

/retest

@omertuc
Copy link
Member

omertuc commented Oct 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2025
@andrej1991
Copy link
Contributor

/test eval-test

@omertuc
Copy link
Member

omertuc commented Oct 21, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@eranco74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/eval-test 655e157 link false /test eval-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3a5a3f0 into rh-ecosystem-edge:main Oct 21, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants