MGMT-21338: allow disabling query model and provider

[zszabo-rh]

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Summary by CodeRabbit

• New Features
  • Added a configurable flag DISABLE_QUERY_MODEL_OVERRIDE (default: false) to control the query model override behavior across environments.
• Documentation
  • Updated README to document the new flag alongside the existing system-prompt flag, including default values and HTTP 422 rejection behavior when enabled.

[openshift-ci-robot]

@zszabo-rh: This pull request references MGMT-21338 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zszabo-rh
Once this PR has been reviewed and has the lgtm label, please assign jhernand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

Adds a new configuration flag DISABLE_QUERY_MODEL_OVERRIDE (default "false")—wired as a template parameter, added to development env defaults, and injected into the Lightspeed stack ConfigMap under customization.

Changes

Cohort / File(s)	Summary
Env defaults template-params.dev.env	Adds DISABLE_QUERY_MODEL_OVERRIDE=false after DISABLE_QUERY_SYSTEM_PROMPT.
Template parameters template.yaml	Adds parameter DISABLE_QUERY_MODEL_OVERRIDE (default "false", description: corresponds to customization.disable_query_model_override).
Lightspeed stack config (ConfigMap) .../lightspeed-stack.yaml (inside lightspeed-stack-config in template.yaml)	Injects disable_query_model_override: ${DISABLE_QUERY_MODEL_OVERRIDE} under the customization section of the Lightspeed stack config.
Documentation README.md	Adds "Configuration flags" section documenting DISABLE_QUERY_SYSTEM_PROMPT and DISABLE_QUERY_MODEL_OVERRIDE, their mapping to Lightspeed customization keys, defaults, and HTTP 422 behavior when enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• MGMT-21336: Update lightspeed-stack.yaml in the template.yaml #76 — Also modifies the lightspeed-stack.yaml ConfigMap's customization section.

Suggested labels

approved, lgtm

Suggested reviewers

• eranco74
• omertuc
• carbonin

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0d13611 and 3220017.

📒 Files selected for processing (3)

• README.md (1 hunks)
• template-params.dev.env (1 hunks)
• template.yaml (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• README.md

🚧 Files skipped from review as they are similar to previous changes (2)

• template.yaml
• template-params.dev.env

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-ci-robot]

@zszabo-rh: This pull request references MGMT-21338 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Summary by CodeRabbit

• New Features
• Added a configurable option to control overriding the query model provider.
• Introduced a new environment/template parameter DISABLE_QUERY_MODEL_PROVIDER_OVERRIDE (default: false) to toggle this behavior across environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

template.yaml (1)

123-125: Parameter + wiring look correct; verify downstream expectation and value type.

• Name/path matches the intent and mirrors disable_query_system_prompt. Good.
• Please confirm lightspeed-stack (PR 475) consumes customization.disable_query_model_provider_override with this exact key and accepts quoted "true"/"false" values; if it requires YAML booleans, we should drop quotes in the parameter defaults.

Would you like me to open a follow-up to standardize boolean params (quoted strings vs YAML booleans) across both flags?

Also applies to: 194-194

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7bedd26 and a3d445b.

📒 Files selected for processing (2)

• template-params.dev.env (1 hunks)
• template.yaml (2 hunks)

🔇 Additional comments (1)

template-params.dev.env (1)

7-7: LGTM: new dev flag added and aligned with template.
Matches the template param name and default. No issues.

[openshift-ci-robot]

@zszabo-rh: This pull request references MGMT-21338 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Summary by CodeRabbit

• New Features
• Added a configurable option to control overriding the query model provider.
• Introduced a new environment/template parameter DISABLE_QUERY_MODEL_OVERRIDE (default: false) to toggle this behavior across environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@zszabo-rh: This pull request references MGMT-21338 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Summary by CodeRabbit

• New Features
• Added a configurable option to control disabling the query model override.
• Introduced a new environment/template parameter DISABLE_QUERY_MODEL_OVERRIDE (default: false) to toggle this behavior across environments; the setting is propagated into the stack configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@zszabo-rh: This pull request references MGMT-21338 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

Expose and propagate a configuration flag to disable client-side model/provider overrides into Lightspeed Stack, aligning assisted-chat deployment parameters with new validation behavior.

Jira: MGMT-21338

Depends on lightspeed-core/lightspeed-stack#475

Summary by CodeRabbit

• New Features
• Added a configurable flag DISABLE_QUERY_MODEL_OVERRIDE (default: false) to control the query model override behavior across environments.
• Documentation
• Updated README to document the new flag alongside the existing system-prompt flag, including default values and HTTP 422 rejection behavior when enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@zszabo-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/eval-test	3220017	link	false	/test eval-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zszabo-rh]

no need for this flag, the feature will be controlled via RBAC