Skip to content

Bump assisted-service-mcp to latest master#149

Merged
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
eranco74:bump_mcp
Aug 26, 2025
Merged

Bump assisted-service-mcp to latest master#149
openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
eranco74:bump_mcp

Conversation

@eranco74
Copy link
Copy Markdown
Collaborator

@eranco74 eranco74 commented Aug 26, 2025

Key changes:

  • Removes cluster name validation from the MCP server (MGMT-21600).
  • Adds metrics for assisted service API calls and latency tracking (MGMT-21387).
  • Improves bot interaction by adding operator names to tool descriptions (MGMT-21356).

Summary by CodeRabbit

  • Chores
    • Updated an internal submodule reference to align with the latest upstream state.
    • No user-facing changes: features, behavior, and interfaces remain unchanged.
    • No performance or stability impact expected.
    • No action required from users or administrators.
    • Documentation and configuration remain the same.

Key changes:
- Removes cluster name validation from the MCP server (MGMT-21600).
- Adds metrics for assisted service API calls and latency tracking (MGMT-21387).
- Improves bot interaction by adding operator names to tool descriptions (MGMT-21356).

Signed-off-by: Eran Cohen <eranco@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 26, 2025

Walkthrough

Updated the assisted-service-mcp submodule reference from commit 2beef39 to d35dec2. No source files, tests, or public APIs changed.

Changes

Cohort / File(s) Summary
Submodule pointer update
assisted-service-mcp
Bumped submodule commit from 2beef39f0bd15cb3232f840181585a17bbad8d7d to d35dec2e39cf18f167af0f2436de8c5bdce318f3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

approved, lgtm

Suggested reviewers

  • carbonin
  • jhernand

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested review from carbonin and keitwb August 26, 2025 07:46
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
assisted-service-mcp (1)

1-1: Submodule bump to d35dec2: downstream impact verified

  • Confirmed no callers or tests in this repo rely on the removed cluster-name validation (grep returned no matches outside the submodule).
  • Noted the addition of new metrics in the assisted-service-mcp submodule (e.g. assisted_service_api_call_duration_seconds, API_CALL_LATENCY, track_tool_usage). This repo does not include any Prometheus scrape or alerting configuration—please ensure your external monitoring scrapes these new metric names and that dashboards/alerts are updated accordingly.
  • The assisted-chat pod template and build scripts still reference the :latest tag for the assisted-service-mcp image (assisted-chat-pod.yaml: image: localhost/local-ai-chat-assisted-service-mcp:latest and scripts/build-images.sh using TAG=latest). Consider pinning to a stable release tag or embedding the SHA in the image tag for reproducible builds and to avoid future churn.

If you’d like help drafting a CHANGELOG entry for these upstream changes or updating any CI/monitoring configs, let me know!

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d5e4813 and e3d34d9.

📒 Files selected for processing (1)
  • assisted-service-mcp (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request

@maorfr
Copy link
Copy Markdown
Collaborator

maorfr commented Aug 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d839c04 into rh-ecosystem-edge:main Aug 26, 2025
6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 28, 2025
@coderabbitai coderabbitai bot mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants