Bump assisted-service-mcp to latest master#149
Bump assisted-service-mcp to latest master#149openshift-merge-bot[bot] merged 1 commit intorh-ecosystem-edge:mainfrom
Conversation
Key changes: - Removes cluster name validation from the MCP server (MGMT-21600). - Adds metrics for assisted service API calls and latency tracking (MGMT-21387). - Improves bot interaction by adding operator names to tool descriptions (MGMT-21356). Signed-off-by: Eran Cohen <eranco@redhat.com>
WalkthroughUpdated the assisted-service-mcp submodule reference from commit 2beef39 to d35dec2. No source files, tests, or public APIs changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
assisted-service-mcp (1)
1-1: Submodule bump to d35dec2: downstream impact verified
- Confirmed no callers or tests in this repo rely on the removed cluster-name validation (grep returned no matches outside the submodule).
- Noted the addition of new metrics in the assisted-service-mcp submodule (e.g.
assisted_service_api_call_duration_seconds,API_CALL_LATENCY,track_tool_usage). This repo does not include any Prometheus scrape or alerting configuration—please ensure your external monitoring scrapes these new metric names and that dashboards/alerts are updated accordingly.- The assisted-chat pod template and build scripts still reference the
:latesttag for the assisted-service-mcp image (assisted-chat-pod.yaml: image: localhost/local-ai-chat-assisted-service-mcp:latestandscripts/build-images.shusingTAG=latest). Consider pinning to a stable release tag or embedding the SHA in the image tag for reproducible builds and to avoid future churn.If you’d like help drafting a CHANGELOG entry for these upstream changes or updating any CI/monitoring configs, let me know!
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
assisted-service-mcp(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
|
/lgtm |
d839c04
into
rh-ecosystem-edge:main
Key changes:
Summary by CodeRabbit