Skip to content

Conversation

@maorfr
Copy link
Collaborator

@maorfr maorfr commented Aug 12, 2025

extract some content from #116

this PR changes the DB references from being llamastack specific since we're introducing another layer of persistence.

Summary by CodeRabbit

  • New Features
    • Introduced ASSISTED_CHAT_DB_SECRET_NAME parameter for database secrets.
  • Refactor
    • Renamed all database environment variables from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_*.
    • Updated default database credentials from “llamastack” to “assisted-chat” (db, user, password).
    • Replaced references to the old DB secret name with ASSISTED_CHAT_DB_SECRET_NAME across configurations.
  • Tests
    • Migrated test storage backends from PostgreSQL to SQLite file-based stores for agents, responses, and registry.

@openshift-ci openshift-ci bot requested review from carbonin and keitwb August 12, 2025 10:04
@coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2025

Walkthrough

Renames PostgreSQL-related environment variables and secrets from LLAMA_STACK_* to ASSISTED_CHAT_* and updates default credentials from “llamastack” to “assisted-chat” across manifests and configs. Test patch switches stores from PostgreSQL to SQLite with file-backed paths. No code logic changes.

Changes

Cohort / File(s) Summary of Changes
Env var and secret renames (assisted chat stack)
assisted-chat-pod.yaml, template.yaml
Renamed all LLAMA_STACK_POSTGRES_* env vars to ASSISTED_CHAT_POSTGRES_*. Updated DB secret name parameter from LLAMA_STACK_DB_SECRET_NAME to ASSISTED_CHAT_DB_SECRET_NAME and references. Updated credentials (user/password/db) from llamastack to assisted-chat.
Client config defaults
config/llama_stack_client_config.yaml
Updated default Postgres db/user/password values from llamastack to assisted-chat in persistence_store, responses_store, and inference_store; env var indirections unchanged.
Test patch: PostgreSQL → SQLite
test/prow/template_patch.diff
Switched persistence_store, responses_store, and inference_store to SQLite with db_path under STORAGE_MOUNT_PATH/sqlite/.db; set namespace: null for agents store. Updated env var references to ASSISTED_CHAT_POSTGRES_.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

lgtm, ok-to-test

Suggested reviewers

  • maorfr
  • carbonin
  • eranco74

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa006b and d2b838d.

📒 Files selected for processing (4)
  • assisted-chat-pod.yaml (2 hunks)
  • config/llama_stack_client_config.yaml (2 hunks)
  • template.yaml (4 hunks)
  • test/prow/template_patch.diff (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Red Hat Konflux / assisted-chat-saas-main-on-pull-request
🔇 Additional comments (13)
config/llama_stack_client_config.yaml (3)

31-33: LGTM! Database credential defaults updated consistently.

The default values for persistence_store have been updated from "llamastack" to "assisted-chat" for db, user, and password fields while maintaining the correct environment variable references.


38-40: LGTM! Database credential defaults updated consistently.

The default values for responses_store have been updated from "llamastack" to "assisted-chat" for db, user, and password fields while maintaining the correct environment variable references.


71-73: LGTM! Database credential defaults updated consistently.

The default values for inference_store have been updated from "llamastack" to "assisted-chat" for db, user, and password fields while maintaining the correct environment variable references.

assisted-chat-pod.yaml (2)

12-21: LGTM! Environment variables renamed consistently.

The PostgreSQL environment variables have been renamed from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_* and the default credential values have been updated from "llamastack" to "assisted-chat" to align with the renaming objectives.


84-88: LGTM! PostgreSQL container credentials updated consistently.

The PostgreSQL container environment variables have been updated from "llamastack" to "assisted-chat" for POSTGRESQL_USER, POSTGRESQL_PASSWORD, and POSTGRESQL_DATABASE to maintain consistency with the database renaming.

test/prow/template_patch.diff (3)

8-15: LGTM! Storage migration from PostgreSQL to SQLite with proper configuration.

The persistence_store has been correctly migrated from PostgreSQL to SQLite with file-based storage. The explicit namespace: null setting for the agents_store is appropriate for the SQLite configuration.


18-24: LGTM! Responses store migrated to SQLite consistently.

The responses_store has been properly migrated from PostgreSQL to SQLite with a dedicated database file path, maintaining consistency with the overall storage backend migration strategy.


33-39: LGTM! Inference store migrated to SQLite consistently.

The inference_store has been properly migrated from PostgreSQL to SQLite with the appropriate database file path, completing the storage backend migration for test environments.

template.yaml (5)

111-113: LGTM! Database secret parameter renamed consistently.

The parameter name has been updated from LLAMA_STACK_DB_SECRET_NAME to ASSISTED_CHAT_DB_SECRET_NAME with the corresponding value "assisted-chat-db" to align with the renaming objectives.


292-296: LGTM! PostgreSQL environment variables renamed in persistence_store configuration.

The environment variable references have been correctly updated from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_* in the persistence_store configuration block within the llama-stack-client-config.


299-303: LGTM! PostgreSQL environment variables renamed in responses_store configuration.

The environment variable references have been correctly updated from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_* in the responses_store configuration block within the llama-stack-client-config.


332-336: LGTM! PostgreSQL environment variables renamed in inference_store configuration.

The environment variable references have been correctly updated from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_* in the inference_store configuration block within the llama-stack-client-config.


404-433: LGTM! Environment variables and secret references updated consistently.

All PostgreSQL-related environment variables in the deployment have been properly renamed from LLAMA_STACK_POSTGRES_* to ASSISTED_CHAT_POSTGRES_* and the secret references have been updated to use ASSISTED_CHAT_DB_SECRET_NAME consistently throughout the deployment configuration.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Member

omertuc commented Aug 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 12, 2025
@omertuc omertuc merged commit 5b817a8 into rh-ecosystem-edge:main Aug 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants